Skip to content
Snippets Groups Projects
Commit 13aaba02 authored by Frank Winklmeier's avatar Frank Winklmeier
Browse files

TrigT1CaloCalibUtils: Mark finalize as ATLAS_NOT_THREAD_SAFE

`L1CaloPprPhos4ShapeMaker::finalize` is calling
`m_signalShapes->Finalize()`, which is marked non-reentrant. So this
method needs to be marked not-thread safe to avoid a compiler warning.
parent 61d2c7ab
No related branches found
No related tags found
No related merge requests found
...@@ -16,7 +16,7 @@ atlas_add_library( TrigT1CaloCalibUtilsLib ...@@ -16,7 +16,7 @@ atlas_add_library( TrigT1CaloCalibUtilsLib
INCLUDE_DIRS ${Boost_INCLUDE_DIRS} ${CORAL_INCLUDE_DIRS} ${CLHEP_INCLUDE_DIRS} INCLUDE_DIRS ${Boost_INCLUDE_DIRS} ${CORAL_INCLUDE_DIRS} ${CLHEP_INCLUDE_DIRS}
PRIVATE_INCLUDE_DIRS ${ROOT_INCLUDE_DIRS} PRIVATE_INCLUDE_DIRS ${ROOT_INCLUDE_DIRS}
DEFINITIONS ${CLHEP_DEFINITIONS} DEFINITIONS ${CLHEP_DEFINITIONS}
LINK_LIBRARIES ${Boost_LIBRARIES} ${CLHEP_LIBRARIES} ${CORAL_LIBRARIES} AthenaBaseComps AthenaKernel AthenaPoolUtilities CaloIdentifier CaloTriggerToolLib EventInfo GaudiKernel Identifier LArCablingLib LArElecCalib RegistrationServicesLib StoreGateLib TrigConfHLTData TrigConfL1Data TrigT1CaloCalibConditions TrigT1CaloCalibToolInterfaces TrigT1CaloCalibToolsLib TrigT1CaloCondSvcLib TrigT1CaloEventLib TrigT1CaloMonitoringToolsLib TrigT1CaloUtilsLib xAODTrigL1Calo LINK_LIBRARIES ${Boost_LIBRARIES} ${CLHEP_LIBRARIES} ${CORAL_LIBRARIES} AthenaBaseComps AthenaKernel AthenaPoolUtilities CaloIdentifier CaloTriggerToolLib CxxUtils EventInfo GaudiKernel Identifier LArCablingLib LArElecCalib RegistrationServicesLib StoreGateLib TrigConfHLTData TrigConfL1Data TrigT1CaloCalibConditions TrigT1CaloCalibToolInterfaces TrigT1CaloCalibToolsLib TrigT1CaloCondSvcLib TrigT1CaloEventLib TrigT1CaloMonitoringToolsLib TrigT1CaloUtilsLib xAODTrigL1Calo
PRIVATE_LINK_LIBRARIES ${ROOT_LIBRARIES} CaloDetDescrLib CaloEvent TrigT1CaloToolInterfaces TrigT1Interfaces xAODEventInfo ) PRIVATE_LINK_LIBRARIES ${ROOT_LIBRARIES} CaloDetDescrLib CaloEvent TrigT1CaloToolInterfaces TrigT1Interfaces xAODEventInfo )
atlas_add_component( TrigT1CaloCalibUtils atlas_add_component( TrigT1CaloCalibUtils
......
/* /*
Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
*/ */
// *************************************************************************** // ***************************************************************************
...@@ -17,7 +17,8 @@ ...@@ -17,7 +17,8 @@
#include <map> #include <map>
// Athena includes // Athena includes
#include "AthenaBaseComps/AthAlgorithm.h" #include "AthenaBaseComps/AthAlgorithm.h"
#include "CxxUtils/checker_macros.h"
#include "GaudiKernel/ITHistSvc.h" #include "GaudiKernel/ITHistSvc.h"
#include "GaudiKernel/ToolHandle.h" #include "GaudiKernel/ToolHandle.h"
...@@ -65,11 +66,10 @@ class L1CaloPprPhos4ShapeMaker : public AthAlgorithm ...@@ -65,11 +66,10 @@ class L1CaloPprPhos4ShapeMaker : public AthAlgorithm
public: public:
// These are the standard Athena public member functions. // These are the standard Athena public member functions.
L1CaloPprPhos4ShapeMaker(const std::string& name, ISvcLocator* pSvcLocator); L1CaloPprPhos4ShapeMaker(const std::string& name, ISvcLocator* pSvcLocator);
virtual ~L1CaloPprPhos4ShapeMaker(){};
virtual StatusCode initialize(); virtual StatusCode initialize() override;
virtual StatusCode execute(); virtual StatusCode execute() override;
virtual StatusCode finalize(); virtual StatusCode finalize ATLAS_NOT_THREAD_SAFE() override;
private: private:
// Unless you provide a class with a default constructor, copy constructor and copy asignment operator // Unless you provide a class with a default constructor, copy constructor and copy asignment operator
......
/* /*
Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
*/ */
#include "TrigT1CaloCalibUtils/L1CaloPprPhos4ShapeMaker.h" #include "TrigT1CaloCalibUtils/L1CaloPprPhos4ShapeMaker.h"
...@@ -431,7 +431,7 @@ StatusCode L1CaloPprPhos4ShapeMaker::execute(){ ...@@ -431,7 +431,7 @@ StatusCode L1CaloPprPhos4ShapeMaker::execute(){
return StatusCode::SUCCESS; return StatusCode::SUCCESS;
} }
StatusCode L1CaloPprPhos4ShapeMaker::finalize(){ StatusCode L1CaloPprPhos4ShapeMaker::finalize ATLAS_NOT_THREAD_SAFE(){
// Place your post-event-loop code here // Place your post-event-loop code here
ATH_MSG_INFO("In finalize()"); ATH_MSG_INFO("In finalize()");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment