Skip to content
Snippets Groups Projects
Commit 179f43c8 authored by scott snyder's avatar scott snyder
Browse files

TrigHLTJetHypo: Fix clang warnings.

Missing override keyword.
Don't use std::move with a non-lvalue.
parent 8246251f
No related branches found
No related tags found
No related merge requests found
......@@ -16,7 +16,7 @@ class AllJetsGrouper: public IJetGrouper{
std::vector<HypoJetGroupVector> group(HypoJetIter&,
HypoJetIter&) const override;
std::optional<HypoJetGroupVector> next();
virtual std::optional<HypoJetGroupVector> next() override;
std::string getName() const override;
std::string toString() const override;
......
......@@ -42,7 +42,7 @@ TrigJetConditionConfig_capacitychecked::getCapacityCheckedCondition() const {
StatusCode TrigJetConditionConfig_capacitychecked::checkVals() const {
if (m_multiplicity < 1) {
if (m_multiplicity < 1u) {
ATH_MSG_ERROR("m_multiplicity = " + std::to_string(m_multiplicity) +
"expected > 0");
return StatusCode::FAILURE;
......
......@@ -116,7 +116,7 @@ TrigJetHypoToolConfig_fastreduction::getCapacityCheckedConditions() const {
// return an invalid optional if any src signals a problem
for(const auto& cm : m_conditionMakers){
conditions.push_back(std::move(cm->getCapacityCheckedCondition()));
conditions.push_back(cm->getCapacityCheckedCondition());
}
return std::make_optional<ConditionPtrs>(std::move(conditions));
......@@ -128,7 +128,7 @@ TrigJetHypoToolConfig_fastreduction::getConditions() const {
ConditionsMT conditions;
for(const auto& cm : m_conditionMakers){
conditions.push_back(std::move(cm->getCapacityCheckedCondition()));
conditions.push_back(cm->getCapacityCheckedCondition());
}
return std::make_optional<ConditionsMT>(std::move(conditions));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment