ByteStreamCnvSvcLegacy: Fix cppcheck warnings.

 - Prohibit copying of class owning memory.
 - Pass class instances by const reference, not by value.

Event/ByteStreamCnvSvcLegacy/ByteStreamCnvSvcLegacy/offline_EventStorage/v5_DataWriter.h

@@ -56,39 +56,39 @@ public:
       \param compression Compression type
       \param compLevel   Compression level
    */
-  DataWriter(const std::string writingPath,     
-	     const std::string fileNameCore,    
-	     const run_parameters_record rPar, 
-	     const std::vector<std::string> fmdStrings, 
+  DataWriter(const std::string& writingPath,     
+	     const std::string& fileNameCore,    
+	     const run_parameters_record& rPar, 
+	     const std::vector<std::string>& fmdStrings, 
 	     const unsigned int startIndex = 1,
 	     const CompressionType compression = NONE,
 	     const unsigned int compLevel = 1); 
 
 
 
-  DataWriter(const std::string writingPath,   
+  DataWriter(const std::string& writingPath,   
 	     boost::shared_ptr<EventStorage::FileNameCallback> theFNCB,
-	     const run_parameters_record rPar, 
-	     const std::string project,
-	     const std::string streamType,
-	     const std::string streamName,
-	     const std::string stream,
+	     const run_parameters_record& rPar, 
+	     const std::string& project,
+	     const std::string& streamType,
+	     const std::string& streamName,
+	     const std::string& stream,
 	     const unsigned int lumiBlockNumber,
-	     const std::string applicationName,
-	     const std::vector<std::string> fmdStrings,
+	     const std::string& applicationName,
+	     const std::vector<std::string>& fmdStrings,
 	     const CompressionType compression = NONE,
 	     const unsigned int compLevel = 1);
 
-  DataWriter(const std::string writingPath,   
-	     const std::string fileNameCore,     
-	     const run_parameters_record rPar, 
-	     const std::string project,
-	     const std::string streamType,
-	     const std::string streamName,
-	     const std::string stream,
+  DataWriter(const std::string& writingPath,   
+	     const std::string& fileNameCore,     
+	     const run_parameters_record& rPar, 
+	     const std::string& project,
+	     const std::string& streamType,
+	     const std::string& streamName,
+	     const std::string& stream,
 	     const unsigned int lumiBlockNumber,
-	     const std::string applicationName,
-	     const std::vector<std::string> fmdStrings,
+	     const std::string& applicationName,
+	     const std::vector<std::string>& fmdStrings,
 	     const CompressionType compression = NONE,
 	     const unsigned int compLevel = 1);
 
@@ -97,16 +97,16 @@ private:
   DataWriter();
 
 
-  void initDW(const std::string writingPath,   
+  void initDW(const std::string& writingPath,   
 	      boost::shared_ptr<EventStorage::FileNameCallback> theFNCB,
-	      const run_parameters_record rPar, 
-	      const std::string project,
-	      const std::string streamType,
-	      const std::string streamName,
-	      const std::string stream,
+	      const run_parameters_record& rPar, 
+	      const std::string& project,
+	      const std::string& streamType,
+	      const std::string& streamName,
+	      const std::string& stream,
 	      const unsigned int lumiBlockNumber,
-	      const std::string applicationName,
-	      const std::vector<std::string> fmdStrings,
+	      const std::string& applicationName,
+	      const std::vector<std::string>& fmdStrings,
 	      const CompressionType compression,
 	      const unsigned int compLevel);
 

Event/ByteStreamCnvSvcLegacy/src/offline_EventStorage/v5_DataBuffer.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -21,6 +21,9 @@ public:
     m_buffer = new char[size];
     m_buffersize = size;
   }
+
+  implementation (const implementation&) = delete;
+  implementation& operator= (const implementation&) = delete;
  
   ~implementation()
   { delete[] m_buffer; }

Event/ByteStreamCnvSvcLegacy/src/offline_EventStorage/v5_DataWriter.cxx

@@ -32,16 +32,16 @@ using EventStorage::SimpleFileName;
 
 // constructors
 DataWriter::
-DataWriter(const string writingPath,   
+DataWriter(const string& writingPath,   
 	   boost::shared_ptr<FileNameCallback> theFNCB,   
-	   const run_parameters_record rPar, 
-	   const std::string project,
-	   const std::string streamType,
-	   const std::string streamName,
-	   const std::string stream,
+	   const run_parameters_record& rPar, 
+	   const std::string& project,
+	   const std::string& streamType,
+	   const std::string& streamName,
+	   const std::string& stream,
 	   const unsigned int lumiBlockNumber,
-	   const std::string applicationName,
-	   const std::vector<std::string> fmdStrings,
+	   const std::string& applicationName,
+	   const std::vector<std::string>& fmdStrings,
 	   const CompressionType compression,
 	   const unsigned int compLevel) 
 {
@@ -50,10 +50,10 @@ DataWriter(const string writingPath,
 }
 
 DataWriter::
-DataWriter(const string writingPath,   
-	   const string fileNameCore,     
-	   const run_parameters_record rPar, 
-	   const freeMetaDataStrings fmdStrings, 
+DataWriter(const string& writingPath,   
+	   const string& fileNameCore,     
+	   const run_parameters_record& rPar, 
+	   const freeMetaDataStrings& fmdStrings, 
 	   const unsigned int startIndex,
 	   const CompressionType compression,
 	   const unsigned int compLevel)
@@ -95,16 +95,16 @@ DataWriter(const string writingPath,
 
 
 DataWriter::
-DataWriter(const string writingPath,   
-	   const string fileNameCore,     
-	   const run_parameters_record rPar, 
-	   const std::string project,
-	   const std::string streamType,
-	   const std::string streamName,
-	   const std::string stream,
+DataWriter(const string& writingPath,   
+	   const string& fileNameCore,     
+	   const run_parameters_record& rPar, 
+	   const std::string& project,
+	   const std::string& streamType,
+	   const std::string& streamName,
+	   const std::string& stream,
 	   const unsigned int lumiBlockNumber,
-	   const std::string applicationName,
-	   const std::vector<std::string> fmdStrings,
+	   const std::string& applicationName,
+	   const std::vector<std::string>& fmdStrings,
 	   const CompressionType compression,
 	   const unsigned int compLevel)
 {
@@ -128,16 +128,16 @@ DataWriter::~DataWriter()
 
 
 void DataWriter::
-initDW(const string writingPath,   
+initDW(const string& writingPath,   
        boost::shared_ptr<FileNameCallback> theFNCB,   
-       const run_parameters_record rPar, 
-       const std::string project,
-       const std::string streamType,
-       const std::string streamName,
-       const std::string stream,
+       const run_parameters_record& rPar, 
+       const std::string& project,
+       const std::string& streamType,
+       const std::string& streamName,
+       const std::string& stream,
        const unsigned int lumiBlockNumber,
-       const std::string applicationName,
-       const std::vector<std::string> fmdStrings,
+       const std::string& applicationName,
+       const std::vector<std::string>& fmdStrings,
        const CompressionType compression,
        const unsigned int compLevel)
 {

Event/ByteStreamCnvSvcLegacy/src/offline_EventStorage/v5_Guid.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 // This is a warapper class for uuid.
@@ -53,10 +53,9 @@ namespace offline_poolCopy_v5  {
         Data1 = g.Data1;
         Data2 = g.Data2;
         Data3 = g.Data3;
-        unsigned int       *p = (unsigned int*)&Data4[0]; 
-        const unsigned int *q = (const unsigned int*)&g.Data4[0];
-        *(p+1) = *(q+1);
-        *p     = *q;
+        for (size_t i = 0; i < 8; i++) {
+          Data4[i] = g.Data4[i];
+        }
       }
       return *this;
     }