MuonD3PDMaker: cmake cleanup, enable flake8, cleanup

Cleanup cmake configuration and delete unused modules. Enable flake8 and
make code compliant.

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/CMakeLists.txt

-################################################################################
-# Package: MuonD3PDMaker
-################################################################################
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 # Declare the package name:
 atlas_subdir( MuonD3PDMaker )
 
 # External dependencies:
-find_package( Boost COMPONENTS filesystem thread system )
 find_package( CLHEP )
 
 # Component(s) in the package:
 atlas_add_component( MuonD3PDMaker
                      src/*.cxx
                      src/components/*.cxx
-                     INCLUDE_DIRS ${Boost_INCLUDE_DIRS} ${CLHEP_INCLUDE_DIRS} 
-                     LINK_LIBRARIES ${Boost_LIBRARIES} ${CLHEP_LIBRARIES} AtlasHepMCLib AthenaBaseComps AthenaKernel AthContainers StoreGateLib SGtests AtlasDetDescr EventInfo EventKernel FourMomUtils xAODMuon xAODTracking xAODTruth GaudiKernel MuonCalibITools MuonIdHelpersLib MuonPattern MuonPrepRawData MuonSegment MuonRecHelperToolsLib MuonRecToolInterfaces MuonSimEvent AnalysisTriggerEvent D3PDMakerUtils TriggerD3PDMakerLib MCTruthClassifierLib McParticleEvent muonEvent TrkGeometry TrkEventPrimitives TrkPrepRawData TrkSegment TrkTrackSummary TrkTruthData TrkExInterfaces TrkToolInterfaces TrigObjectMatchingLib TrigInDetEvent TrigMuonEvent TrackRecordLib MuonTruthAlgsLib )
+                     INCLUDE_DIRS ${CLHEP_INCLUDE_DIRS}
+                     LINK_LIBRARIES ${CLHEP_LIBRARIES} AtlasHepMCLib AthenaBaseComps AthenaKernel AthContainers StoreGateLib AtlasDetDescr EventKernel FourMomUtils xAODMuon xAODTracking xAODTruth GaudiKernel MuonCalibITools MuonIdHelpersLib MuonPattern MuonPrepRawData MuonSegment MuonRecHelperToolsLib MuonRecToolInterfaces MuonSimEvent AnalysisTriggerEvent D3PDMakerUtils MCTruthClassifierLib McParticleEvent muonEvent TrkGeometry TrkEventPrimitives TrkPrepRawData TrkSegment TrkTrackSummary TrkTruthData TrkExInterfaces TrkToolInterfaces TrigMuonEvent TrackRecordLib MuonTruthAlgsLib )
 
 # Install files from the package:
-atlas_install_python_modules( python/*.py )
+atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )
 atlas_install_joboptions( share/*.py )
 

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/CscPrepDataD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
-
-import MuonD3PDMaker
-import D3PDMakerCoreComps
-from D3PDMakerCoreComps.D3PDObject import D3PDObject
-from D3PDMakerConfig.D3PDMakerFlags import D3PDMakerFlags
-
-
-def makeD3PDObject (name, prefix, object_name, getter = None,
-                    sgkey = 'CSC_Clusters',
-                    typename = 'Muon::CscPrepDataContainer',
-                    label = 'CscPrepData'):
-    if not getter:
-        from MuonD3PDMaker.MuonD3PDMakerConf import D3PD__CscPrepDataCollectionGetterTool
-        getter = D3PD__CscPrepDataCollectionGetterTool \
-                 (name + '_Getter',
-                  SGKey = sgkey,
-                  TypeName = typename,
-                  Label = label)
-    getter.OutputLevel=1    
-    return D3PDMakerCoreComps.VectorFillerTool (name,
-                                                Prefix = prefix,
-                                                Getter = getter,
-                                                ObjectName = object_name, OutputLevel=1)
-
-
-CscPrepDataD3PDObject =  D3PDObject (makeD3PDObject, 'csc_', 'CscPrepDataD3PDObject')
-
-CscPrepDataD3PDObject.defineBlock (0, 'PrepData', MuonD3PDMaker.CscPrepDataFillerTool)

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/MDTSimHitD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
-
-# $Id: MDTSimHitD3PDObject.py 508173 2012-06-29 11:47:55Z ssnyder $
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 # Import all needed modules:
 import MuonD3PDMaker
-import D3PDMakerCoreComps
 from D3PDMakerCoreComps.D3PDObject  import make_SGDataVector_D3PDObject
-from D3PDMakerConfig.D3PDMakerFlags import D3PDMakerFlags
-from D3PDMakerCoreComps.D3PDObject  import D3PDObject
 
 # Create the configurable:
 MDTSimHitD3PDObject = \

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/MdtPrepDataD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
-
-import MuonD3PDMaker
-import D3PDMakerCoreComps
-from D3PDMakerCoreComps.D3PDObject import D3PDObject
-from D3PDMakerConfig.D3PDMakerFlags import D3PDMakerFlags
-
-
-def makeD3PDObject (name, prefix, object_name, getter = None,
-                    sgkey = 'MDT_DriftCircles',
-                    typename = 'Muon::MdtPrepDataContainer',
-                    label = 'MdtPrepData'):
-    if not getter:
-        from MuonD3PDMaker.MuonD3PDMakerConf import D3PD__MdtPrepDataCollectionGetterTool
-        getter = D3PD__MdtPrepDataCollectionGetterTool \
-                 (name + '_Getter',
-                  SGKey = sgkey,
-                  TypeName = typename,
-                  Label = label)
-    getter.OutputLevel=1    
-    return D3PDMakerCoreComps.VectorFillerTool (name,
-                                                Prefix = prefix,
-                                                Getter = getter,
-                                                ObjectName = object_name, OutputLevel=1)
-
-
-MdtPrepDataD3PDObject =  D3PDObject (makeD3PDObject, 'mdt_', 'MdtPrepDataD3PDObject')
-
-MdtPrepDataD3PDObject.defineBlock (0, 'PrepData', MuonD3PDMaker.MdtPrepDataFillerTool)

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/MuonD3PDObject.py

@@ -4,23 +4,13 @@
 import MuonD3PDMaker
 import D3PDMakerCoreComps
 import EventCommonD3PDMaker
-import TriggerD3PDMaker
 import TrackD3PDMaker
-from TriggerD3PDMaker.defineTriggerBits   import defineTriggerBits
 from D3PDMakerCoreComps.D3PDObject        import make_SGDataVector_D3PDObject
-from D3PDMakerCoreComps.D3PDObject         import DeferArg
 from D3PDMakerCoreComps.SimpleAssociation import SimpleAssociation
-from D3PDMakerCoreComps.IndexAssociation  import IndexAssociation
 from D3PDMakerConfig.D3PDMakerFlags       import D3PDMakerFlags
-from D3PDMakerCoreComps.ContainedVectorMultiAssociation import ContainedVectorMultiAssociation
 import TruthD3PDMaker
 
 from RecExConfig.RecFlags import rec
-from RecExConfig.ObjKeyStore import cfgKeyStore
-
-from AthenaCommon.AppMgr import ToolSvc
-from AthenaCommon.Include import include
-
 from MuonD3PDMaker.MuonD3PDMakerFlags    import MuonD3PDFlags
 
 

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/MuonSegmentD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 import MuonD3PDMaker
-import D3PDMakerCoreComps
-import EventCommonD3PDMaker
 from D3PDMakerCoreComps.D3PDObject import make_SGDataVector_D3PDObject
 from D3PDMakerConfig.D3PDMakerFlags import D3PDMakerFlags
 
 from MuonD3PDMaker.MuonD3PDMakerFlags    import MuonD3PDFlags
 from RecExConfig.RecFlags import rec
 
-#from MuonD3PDMaker.MuonD3PDMakerConf import MuonWZTruthTool
-#TruthTool = MuonWZTruthTool()
-#ToolSvc += TruthTool
-
 MuonSegmentD3PDObject = \
            make_SGDataVector_D3PDObject ('Trk::SegmentCollection',
                                          D3PDMakerFlags.MuonSegmentSGKey(),

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/MuonSegmentTruthD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
-
-import MuonD3PDMaker
-import D3PDMakerCoreComps
-import EventCommonD3PDMaker
-from D3PDMakerCoreComps.D3PDObject import make_SGDataVector_D3PDObject
-from D3PDMakerCoreComps.SimpleAssociation import SimpleAssociation
-from D3PDMakerConfig.D3PDMakerFlags import D3PDMakerFlags
-
-from RecExConfig.RecFlags import rec
-
-MuonSegmentTruthD3PDObject = \
-                   make_SGDataVector_D3PDObject ('Trk::SegmentCollection',
-                                                 'MuonSegments',
-                                                 'mu_segmentTruth_', 'MuonSegmentTruthD3PDObject')
-
-MuonSegmentTruthD3PDObject.defineBlock (1, 'PatternTruthCombination',
-                                        MuonD3PDMaker.MuonSegmentTruthFillerTool)
-

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/MuonSpShowerD3PDObject.py

 # Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
 
-# $Id$
 #
 # @file MuonD3PDMaker/python/MuonSpShowerD3PDObject.py
 # @author Michiru Kaneda <Michiru.Kaneda@cern.ch>
@@ -8,7 +7,6 @@
 # @brief MuonSpShower filler tool
 #
 
-import D3PDMakerCoreComps
 from D3PDMakerCoreComps.D3PDObject import make_SGDataVector_D3PDObject
 from MuonD3PDMaker.MuonD3PDMakerConf import D3PD__MuonSpShowerFillerTool as MuonSpShowerFillerTool
 

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/RpcPrepDataD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
-
-import MuonD3PDMaker
-import D3PDMakerCoreComps
-from D3PDMakerCoreComps.D3PDObject import D3PDObject
-from D3PDMakerConfig.D3PDMakerFlags import D3PDMakerFlags
-
-
-def makeD3PDObject (name, prefix, object_name, getter = None,
-                    sgkey = 'RPC_Measurements',
-                    typename = 'Muon::RpcPrepDataContainer',
-                    label = 'RpcPrepData'):
-    if not getter:
-        from MuonD3PDMaker.MuonD3PDMakerConf import D3PD__RpcPrepDataCollectionGetterTool
-        getter = D3PD__RpcPrepDataCollectionGetterTool \
-                 (name + '_Getter',
-                  SGKey = sgkey,
-                  TypeName = typename,
-                  Label = label)
-    getter.OutputLevel=1    
-    return D3PDMakerCoreComps.VectorFillerTool (name,
-                                                Prefix = prefix,
-                                                Getter = getter,
-                                                ObjectName = object_name, OutputLevel=1)
-
-
-RpcPrepDataD3PDObject =  D3PDObject (makeD3PDObject, 'rpc_', 'RpcPrepDataD3PDObject')
-
-RpcPrepDataD3PDObject.defineBlock (0, 'PrepData', MuonD3PDMaker.RpcPrepDataFillerTool)

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/TgcPrepDataD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
-
-import MuonD3PDMaker
-import D3PDMakerCoreComps
-from D3PDMakerCoreComps.D3PDObject import D3PDObject
-from D3PDMakerConfig.D3PDMakerFlags import D3PDMakerFlags
-
-
-def makeD3PDObject (name, prefix, object_name, getter = None,
-                    sgkey = 'TGC_Measurements',
-                    #sgkey = 'TGC_MeasurementsPriorBC',
-                    #sgkey = 'TGC_MeasurementsNextBC',
-                    typename = 'Muon::TgcPrepDataContainer',
-                    label = 'TgcPrepData'):
-    if not getter:
-        from MuonD3PDMaker.MuonD3PDMakerConf import D3PD__TgcPrepDataCollectionGetterTool
-        getter = D3PD__TgcPrepDataCollectionGetterTool \
-                 (name + '_Getter',
-                  SGKey = sgkey,
-                  TypeName = typename,
-                  Label = label)
-    getter.OutputLevel=1    
-    return D3PDMakerCoreComps.VectorFillerTool (name,
-                                                Prefix = prefix,
-                                                Getter = getter,
-                                                ObjectName = object_name, OutputLevel=1)
-
-
-TgcPrepDataD3PDObject =  D3PDObject (makeD3PDObject, 'tgc_', 'TgcPrepDataD3PDObject')
-
-TgcPrepDataD3PDObject.defineBlock (0, 'PrepData', MuonD3PDMaker.TgcPrepDataFillerTool)

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/TrackRecordD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
-
-# $Id: TrackRecordD3PDObject.py
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 # Import all needed modules:
 import MuonD3PDMaker
-import D3PDMakerCoreComps
-from D3PDMakerCoreComps.resolveSGKey import testSGKey
-from D3PDMakerConfig.D3PDMakerFlags  import D3PDMakerFlags
-from D3PDMakerCoreComps.D3PDObject   import D3PDObject
 from D3PDMakerCoreComps.D3PDObject   import make_SGDataVector_D3PDObject
 
 

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/TruthMuonD3PDObject.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 # @file  MuonD3PDMaker/python/TruthMuonD3PDObject.py
 # $author  Srivas Prasad <srivas.prasad@cern.ch>
@@ -9,7 +9,6 @@
 import MuonD3PDMaker
 import EventCommonD3PDMaker
 from D3PDMakerCoreComps.D3PDObject         import make_SGDataVector_D3PDObject
-from D3PDMakerCoreComps.resolveSGKey       import testSGKey
 from D3PDMakerConfig.D3PDMakerFlags        import D3PDMakerFlags
 from AthenaCommon.AlgSequence              import AlgSequence
 from RecExConfig.ObjKeyStore               import cfgKeyStore

PhysicsAnalysis/D3PDMaker/MuonD3PDMaker/python/muonD3PD.py

-# Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
-# $Id$
 #
 # @file MuonD3PDMaker/python/muonD3PD.py
 # @author srivas prasad <srivas.prasad@cern.ch>