Merge branch 'clang.EventSelectorAthenaPool-20201112' into 'master'

EventSelectorAthenaPool+TrkPatternParameters+TrkDetDescrSvc: Fix clang warnings.

See merge request atlas/athena!38160

Database/AthenaPOOL/EventSelectorAthenaPool/src/EventSelectorAthenaPool.cxx

@@ -100,7 +100,7 @@ StatusCode EventSelectorAthenaPool::initialize() {
    }
    boost::char_separator<char> sep_coma(","), sep_hyph("-");
    boost::tokenizer  ranges(m_skipEventRangesProp.value(), sep_coma);
-   for( const std::string r: ranges ) {
+   for( const std::string& r: ranges ) {
       boost::tokenizer  fromto(r, sep_hyph);
       auto from_iter = fromto.begin();
       std::stringstream strstr1( *from_iter );

Tracking/TrkDetDescr/TrkDetDescrSvc/TrkDetDescrSvc/TrackingGeometryMirror.h

@@ -44,7 +44,7 @@ namespace Trk {
 
       template <class T_Ostream>
       void dump(T_Ostream &out, const std::string &head) const {
-         for(const std::pair<const Layer*,int> &bound_layers : m_boundaryLayers) {
+         for(const std::pair<const Layer* const ,int> &bound_layers : m_boundaryLayers) {
             out << head << " [" << bound_layers.second  << "] ";
             dumpLayer(out, "",bound_layers.first);
          }

Tracking/TrkEvent/TrkPatternParameters/TrkPatternParameters/PatternTrackParameters.h

@@ -50,7 +50,8 @@ namespace Trk {
       // Main methods
       ///////////////////////////////////////////////////////////////////
 
-      const Surface&   associatedSurface ()     const {return   *m_surface;}
+      virtual
+      const Surface&   associatedSurface ()     const override {return   *m_surface;}
       bool             iscovariance      ()     const {return   m_covariance != nullptr ;}
       double           sinPhi            ()     const;
       double           cosPhi            ()     const;
@@ -110,8 +111,8 @@ namespace Trk {
       // Print
       ///////////////////////////////////////////////////////////////////
 
-      std::ostream& dump(std::ostream&) const;
-      MsgStream&    dump(MsgStream&   ) const;	
+      virtual std::ostream& dump(std::ostream&) const override;
+      virtual MsgStream&    dump(MsgStream&   ) const override;
 
     protected: