Merge branch 'flake8_indetmon' into 'master'

InDetGlobalMonitoringRun3Test: cmake fixes, enable flake8

See merge request atlas/athena!39074

InnerDetector/InDetMonitoring/InDetGlobalMonitoringRun3Test/CMakeLists.txt

-################################################################################
-# Package: InDetGlobalMonitoringRun3Test
-################################################################################
+# Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 
 # Declare the package name:
 atlas_subdir( InDetGlobalMonitoringRun3Test )
 
-# External dependencies:
-find_package( ROOT COMPONENTS Core MathCore Hist )
-
 # Component(s) in the package:
 atlas_add_component( InDetGlobalMonitoringRun3Test
    InDetGlobalMonitoringRun3Test/*.h src/*.cxx src/components/*.cxx
-   INCLUDE_DIRS ${ROOT_INCLUDE_DIRS}
-   PRIVATE_LINK_LIBRARIES InDetConditionsSummaryService
-   LINK_LIBRARIES ${ROOT_LIBRARIES} AthenaMonitoringLib AtlasDetDescr
-   GaudiKernel InDetRawData InDetPrepRawData TrkTrack InDetByteStreamErrors 
-   AthenaPoolUtilities GeoPrimitives xAODEventInfo EventPrimitives InDetIdentifier
-   InDetReadoutGeometry InDetRIO_OnTrack LWHists TrkParameters TrkSpacePoint VxVertex TrkVertexFitterInterfaces xAODTracking
-   TrkTrackSummary TrkToolInterfaces PixelCablingLib PixelGeoModelLib PathResolver BeamSpotConditionsData 
-   InDetTrackSelectionToolLib )
+   LINK_LIBRARIES AthenaMonitoringKernelLib AthenaMonitoringLib AtlasDetDescr BeamSpotConditionsData EventPrimitives GaudiKernel InDetConditionsSummaryService InDetIdentifier InDetPrepRawData InDetTrackSelectionToolLib PixelGeoModelLib StoreGateLib TrkEventPrimitives TrkToolInterfaces TrkTrack TrkTrackSummary xAODTracking )
 
-atlas_install_python_modules( python/*.py )
+atlas_install_python_modules( python/*.py POST_BUILD_CMD ${ATLAS_FLAKE8} )

InnerDetector/InDetMonitoring/InDetGlobalMonitoringRun3Test/python/InDetGlobalPrimaryVertexMonAlgCfg.py

@@ -9,8 +9,6 @@
 @brief Configuration for Run 3 based on InDetGlobalPrimaryVertexMonTool.cxx
 """
 
-from math import pi as M_PI
-
 def InDetGlobalPrimaryVertexMonAlgCfg(helper, alg, **kwargs):
 
     # this creates a "pvGroup" called "alg" which will put its histograms into the subdirectory "PrimaryVertex"

InnerDetector/InDetMonitoring/InDetGlobalMonitoringRun3Test/python/InDetGlobalTrackMonAlgCfg.py

@@ -13,18 +13,14 @@ from math import pi as M_PI
 
 def InDetGlobalTrackMonAlgCfg(helper, alg, **kwargs):
 
-    # values	
-    m_doIBL = True
+    # values
     m_nBinsEta = 50
     m_nBinsPhi = 50
     m_trackBin = 75
     m_c_etaRange = 2.5
-    m_c_etaTrackletsMin = 2.4
-    m_c_etaTrackletsMax = 2.7
     m_c_etaRangeTRT = 2.0
     m_c_range_LB = 3000
     m_trackMax = 75
-    #M_PI = math.pi
 
     # this creates a "trackGroup" called "alg" which will put its histograms into the subdirectory "Track"
     trackGroup = helper.addGroup(alg, 'Track')