Fix filling of monitoring histograms with kVec/kVecUO options.
Histograms with those options were not filled at all, there was a logic bug in `VecHistogramFiller1D::fill` method. The fix is limited to that class only and I have added a unit test for those two options. I also noticed that HistogramDef contents is not initialized and I switched to using MockHistogramDef in couple of other unit tests where I think it may be important to have properly initialized definition. And I think HistogramDef needs a default constructor which makes instances in a known state (or per-member initializers).
Showing
- Control/AthenaMonitoringKernel/AthenaMonitoringKernel/HistogramFiller.h 2 additions, 0 deletions...MonitoringKernel/AthenaMonitoringKernel/HistogramFiller.h
- Control/AthenaMonitoringKernel/src/HistogramFiller/VecHistogramFiller1D.h 2 additions, 2 deletions...nitoringKernel/src/HistogramFiller/VecHistogramFiller1D.h
- Control/AthenaMonitoringKernel/test/HistogramFillerRebinable1DTestSuite.cxx 2 additions, 1 deletion...toringKernel/test/HistogramFillerRebinable1DTestSuite.cxx
- Control/AthenaMonitoringKernel/test/HistogramFillerRebinable2DTestSuite.cxx 2 additions, 1 deletion...toringKernel/test/HistogramFillerRebinable2DTestSuite.cxx
- Control/AthenaMonitoringKernel/test/HistogramFillerVec1DTestSuite.cxx 192 additions, 0 deletions...naMonitoringKernel/test/HistogramFillerVec1DTestSuite.cxx
Loading
Please register or sign in to comment