Merge branch 'clang.FastTRT_Digitization-20210104' into 'master'

FastTRT_Digitization+InDetEtaDependentCuts+GeoModelEnvelopes: Fix clang warnings.

See merge request !39457

AtlasGeometryCommon/GeoModelEnvelopes/src/ForDetEnvelopeTool.h

 /*
-  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef ForDetEnvelopeTool_h 
@@ -8,7 +8,7 @@
 #include "GeoModelUtilities/GeoModelTool.h"
 class ForDetEnvelopeManager;
 
-class ForDetEnvelopeTool : public GeoModelTool 
+class ForDetEnvelopeTool final : public GeoModelTool 
 {
  public:
 

InnerDetector/InDetDigitization/FastTRT_Digitization/src/TRTFastDigitizationTool.cxx

 /*
-  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 
 ///////////////////////////////////////////////////////////////////
@@ -391,7 +391,7 @@ StatusCode TRTFastDigitizationTool::produceDriftCircles(const EventContext& ctx)
 
       if ( m_useTrtElectronPidTool ) {
 
-        double position = ( fabs(BEC) == 1 ? hitGlobalPosition.z() : hitGlobalPosition.perp() );
+        double position = ( std::abs(BEC) == 1 ? hitGlobalPosition.z() : hitGlobalPosition.perp() );
 
         double probability;
         if ( abs( particleEncoding ) == 11 && kineticEnergy > 5000. ) {  // electron

InnerDetector/InDetRecTools/InDetEtaDependentCuts/InDetEtaDependentCuts/InDetEtaDependentCutsSvc.h

 /*
-  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2021 CERN for the benefit of the ATLAS collaboration
 */
 #ifndef INDETETADEPENDENTCUTS_INDETETADEPENDENTCUTSSVC_H
 #define INDETETADEPENDENTCUTS_INDETETADEPENDENTCUTSSVC_H
@@ -18,9 +18,9 @@
 #include "GaudiKernel/ISvcLocator.h"
 
 namespace InDet {
-  class InDetEtaDependentCutsSvc: virtual public IInDetEtaDependentCutsSvc,
-                                  public AthService {
-
+  class InDetEtaDependentCutsSvc final
+    : virtual public IInDetEtaDependentCutsSvc, public AthService
+  {
     /////////////////////////////////////////////////////////////////// 
     // Public methods: 
     ///////////////////////////////////////////////////////////////////