Merge branch 'cppcheck.MuonAlignmentData-20200902' into 'master'

MuonAlignmentData: Fix cppcheck warnings.

See merge request atlas/athena!36127

MuonSpectrometer/MuonAlignment/MuonAlignmentData/MuonAlignmentData/CscInternalAlignmentPar.h

@@ -17,7 +17,7 @@ class CscInternalAlignmentPar : public MuonAlignmentPar {
   // destructor
   virtual ~CscInternalAlignmentPar() override = default;
 
-  void setAmdbId(std::string type, int jff, int jzz, int job, int wireLayer);
+  void setAmdbId(const std::string& type, int jff, int jzz, int job, int wireLayer);
   void getAmdbId(std::string& type, int& jff, int& jzz, int& job, int& wireLayer) const;
 
   void setParameters(float s, float z, float t, 

MuonSpectrometer/MuonAlignment/MuonAlignmentData/MuonAlignmentData/MuonAlignmentPar.h

@@ -21,7 +21,7 @@ class MuonAlignmentPar {
   Identifier  identify() const {return m_stationId;}
   std::string key()      const {return m_stationKey;}
 
-  void setAmdbId(std::string type, int jff, int jzz, int job);
+  void setAmdbId(const std::string& type, int jff, int jzz, int job);
   void getAmdbId(std::string& type, int& jff, int& jzz, int& job) const;
 
   bool isNew() const        {return m_isNew;}

MuonSpectrometer/MuonAlignment/MuonAlignmentData/src/CscInternalAlignmentPar.cxx

@@ -37,7 +37,7 @@ void CscInternalAlignmentPar::getParameters(float& s, float& z, float& t,
   rotT = m_rotT;
 }
 
-void CscInternalAlignmentPar::setAmdbId(std::string type, int jff, int jzz, int job, int wireLayer) 
+void CscInternalAlignmentPar::setAmdbId(const std::string& type, int jff, int jzz, int job, int wireLayer) 
 {
   m_Type = type;
   m_Jff  = jff;

MuonSpectrometer/MuonAlignment/MuonAlignmentData/src/MuonAlignmentPar.cxx

@@ -8,7 +8,7 @@ MuonAlignmentPar::MuonAlignmentPar() :
   m_Jff(0), m_Jzz(0), m_Job(0), m_isNew(false)
 { }
 
-void MuonAlignmentPar::setAmdbId(std::string type, int jff, int jzz, int job) 
+void MuonAlignmentPar::setAmdbId(const std::string& type, int jff, int jzz, int job) 
 {
   m_Type = type;
   m_Jff  = jff;