Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
athena
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Peter Sherwood
athena
Commits
c33d3dff
Commit
c33d3dff
authored
4 years ago
by
scott snyder
Committed by
scott snyder
4 years ago
Browse files
Options
Downloads
Patches
Plain Diff
SGComps: Fix cppcheck warnings.
- Parameter name ordering mismatch. - Use preincrement rather than postincrement.
parent
b9ffea6f
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
Control/SGComps/src/ProxyProviderSvc.cxx
+2
-2
2 additions, 2 deletions
Control/SGComps/src/ProxyProviderSvc.cxx
Control/SGComps/src/SGFolder.h
+3
-3
3 additions, 3 deletions
Control/SGComps/src/SGFolder.h
with
5 additions
and
5 deletions
Control/SGComps/src/ProxyProviderSvc.cxx
+
2
−
2
View file @
c33d3dff
/*
Copyright (C) 2002-20
19
CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-20
20
CERN for the benefit of the ATLAS collaboration
*/
#include
<algorithm>
...
...
@@ -261,7 +261,7 @@ ProxyProviderSvc::retrieveProxy(const CLID& id, const std::string& key,
const
EventContext
&
ctx
=
contextFromStore
(
store
);
SG
::
TransientAddress
pTAd
(
id
,
key
);
pAPiterator
iProvider
(
m_providers
.
begin
()),
iEnd
(
m_providers
.
end
());
for
(;
iProvider
!=
iEnd
;
iProvider
++
)
{
for
(;
iProvider
!=
iEnd
;
++
iProvider
)
{
if
(
((
*
iProvider
)
->
updateAddress
(
store
.
storeID
(),
&
pTAd
,
ctx
)).
isSuccess
()
)
{
pTAd
.
setProvider
(
*
iProvider
,
store
.
storeID
());
...
...
This diff is collapsed.
Click to expand it.
Control/SGComps/src/SGFolder.h
+
3
−
3
View file @
c33d3dff
// -*- c++ -*-
/*
Copyright (C) 2002-20
17
CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-20
20
CERN for the benefit of the ATLAS collaboration
*/
#ifndef SGCOMPS_FOLDER_H
...
...
@@ -46,8 +46,8 @@ namespace SG {
public:
/// \name structors
//@{
Folder
(
const
std
::
string
&
nam
e
,
const
std
::
string
&
typ
e
,
Folder
(
const
std
::
string
&
typ
e
,
const
std
::
string
&
nam
e
,
const
IInterface
*
parent
);
virtual
~
Folder
()
override
;
//@}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment