Merge branch 'duplicate_sid' into 'master'

Change GenericMetadataTool duplicate sid return code

See merge request atlas/athena!21897

Control/AthenaKernel/AthenaKernel/GenericMetadataTool.icc

@@ -322,8 +322,8 @@ StatusCode GenericMetadataTool<T,U>::buildAthenaInterface(const std::string& inp
   // Make sure sid does not already exist in the MetaCont
   for (auto it = mc->sources().begin(); it != mc->sources().end(); ++it) {
     if (*it==sid) {
-      ATH_MSG_ERROR("Metadata already exists for sid " << sid);
-      return StatusCode::FAILURE;   // Fail if sid already exists
+      ATH_MSG_WARNING("Metadata already exists for sid " << sid);
+      return StatusCode::SUCCESS;   // Assume success if sid already exists
     }
   }
 

Control/AthenaKernel/AthenaKernel/GenericMetadataToolNoAux.icc

@@ -290,8 +290,8 @@ StatusCode GenericMetadataToolNoAux<T>::buildAthenaInterface(const std::string&
   // Make sure sid does not already exist in the MetaCont
   for (auto it = mc->sources().begin(); it != mc->sources().end(); ++it) {
     if (*it==sid) {
-      ATH_MSG_ERROR("Metadata already exists for sid " << sid);
-      return StatusCode::FAILURE;   // Fail if sid already exists
+      ATH_MSG_WARNING("Metadata already exists for sid " << sid);
+      return StatusCode::SUCCESS;   // Assume success if sid already exists
     }
   }