Merge branch 'clang.MuonCombinedTrackFindingTools-20201215' into 'master'

MuonCombinedTrackFindingTools+MuonTrackFinderTools+MuonTrackSteeringTools: Fix clang warnings

See merge request atlas/athena!39220

MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools/src/MuonSegmentRegionRecoveryTool.h

@@ -110,15 +110,15 @@ namespace Muon {
     virtual ~MuonSegmentRegionRecoveryTool () = default;
     
     /** @brief AlgTool initialize */
-    StatusCode initialize();
+    virtual StatusCode initialize() override;
     
     /** @brief AlgTool finalize */
-    StatusCode finalize();
+    virtual StatusCode finalize() override;
     
     /** @brief returns a new track with segments recovered using RegionSelector*/
-    Trk::Track* recover( const Trk::Track& track ) const;
+    virtual Trk::Track* recover( const Trk::Track& track ) const override;
     
-    void cleanUp() const override;
+    virtual void cleanUp() const override;
 
   private:
 

MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackSteeringTools/src/MooCandidateMatchingTool.h

@@ -68,13 +68,13 @@ namespace Muon {
     MooCandidateMatchingTool(const std::string&, const std::string&, const IInterface*);
     
     /** destructor */
-    ~MooCandidateMatchingTool();
+    virtual ~MooCandidateMatchingTool();
     
     /** initialize method, method taken from bass-class AlgTool */
-    StatusCode initialize();
+    virtual StatusCode initialize() override;
 
     /** finialize method, method taken from bass-class AlgTool */
-    StatusCode finalize();
+    virtual StatusCode finalize() override;
     
     /** @brief access to tool interface */
     static const InterfaceID& interfaceID() { return IID_MooCandidateMatchingTool; }
@@ -89,7 +89,7 @@ namespace Muon {
     bool match( const MuPatCandidateBase& entry1, const MuPatSegment& entry2, bool useTightCuts = false ) const;
 
     /** @brief match a track with a segment */
-    bool match( const Trk::Track& track, const MuonSegment& segment, bool useTightCuts ) const;
+    virtual bool match( const Trk::Track& track, const MuonSegment& segment, bool useTightCuts ) const override;
 
     /** @brief calculate the info needed for the matching decision */
     void calculateTrackSegmentMatchResult( const MuPatTrack& entry1, const MuPatSegment& entry2, MooTrackSegmentMatchResult& info ) const;

Reconstruction/MuonIdentification/MuonCombinedTrackFindingTools/src/MuonLayerAmbiguitySolverTool.h

@@ -29,13 +29,13 @@ namespace Muon {
     /** Default AlgTool functions */
     MuonLayerAmbiguitySolverTool(const std::string& type, const std::string& name, const IInterface* parent);
     virtual ~MuonLayerAmbiguitySolverTool()=default;
-    StatusCode initialize();
+    virtual StatusCode initialize() override;
 
     /**IMuonLayerAmbiguitySolverTool interface: find */   
-    void resolveOverlaps( const std::vector<Muon::MuonLayerRecoData>& allLayers, std::vector< MuonCandidate >& resolvedCandidates ) const;
+    virtual void resolveOverlaps( const std::vector<Muon::MuonLayerRecoData>& allLayers, std::vector< MuonCandidate >& resolvedCandidates ) const override;
 
 
-    void cleanUp() const override;
+    virtual void cleanUp() const override;
 
   private:
     void buildLayerVec( const std::vector<MuonLayerRecoData>& allLayers,