LArRawEvent: Fix cppcheck warnings.

 - Prefer to pass large objects by const reference instead of by value.
 - Avoid post-increment of user iterators.

LArCalorimeter/LArRawEvent/LArRawEvent/LArRawSC.h

@@ -43,7 +43,7 @@ class LArRawSC  {
       @param[in] gain_value  Gain
       @param[in] sample_value Reference of vector with ADC samples
   */
-  LArRawSC(const HWIdentifier & channel_value, const short chan, const unsigned int sourceId, const std::vector < int > & energies, const std::vector<unsigned short> bcids, std::vector<bool> satur):
+  LArRawSC(const HWIdentifier & channel_value, const short chan, const unsigned int sourceId, const std::vector < int > & energies, const std::vector<unsigned short>& bcids, std::vector<bool>& satur):
     m_hardwareID(channel_value), m_chan(chan),m_sourceId(sourceId), m_energies(energies), m_BCId(bcids), m_satur(satur) {}
 
   LArRawSC(const HWIdentifier & channel_value,
@@ -87,12 +87,12 @@ class LArRawSC  {
     /** @brief Set energies .
         @param[in] samples  vector of energies
     */
-    void setEnergies( std::vector < int > energies);
+    void setEnergies( const std::vector < int >& energies);
 
     /** @brief Set bcids.
         @param[in] samples  vector of bcids
     */
-    void setBCIds( std::vector < unsigned short > bcids);
+    void setBCIds( const std::vector < unsigned short >& bcids);
 
     /** @brief Destructor */
     virtual ~LArRawSC() { }

LArCalorimeter/LArRawEvent/src/LArRawSC.cxx

@@ -35,14 +35,12 @@ LArRawSC::operator std::string() const{
 }
 
 // set method
-void LArRawSC::setEnergies(std::vector<int> energies)
+void LArRawSC::setEnergies(const std::vector<int>& energies)
 {
-  m_energies.clear();
   m_energies = energies;
 }
 
-void LArRawSC::setBCIds(std::vector<unsigned short> bcids)
+void LArRawSC::setBCIds(const std::vector<unsigned short>& bcids)
 {
-  m_BCId.clear();
   m_BCId = bcids;
 }

LArCalorimeter/LArRawEvent/src/LArRawSCContainer.cxx

@@ -24,12 +24,8 @@ LArRawSCContainer::operator std::string () const {
  
  LArRawSCContainer::const_iterator it ;
  int counter = 0 ;
- const LArRawSC * digit ;    
- 
-     for(it = this->begin() ; it != this->end() ; it++ ){ // Loop over Hits
-     
-       digit = *it ;
-             
+
+     for (const LArRawSC * digit : *this) { // Loop over Hits
        sprintf( stCounter , "%d" , counter ) ;     
         
        digitContainerString += "LArRawSC[" ;