Trk::Track clarify changes due to const correctness in documentation. Get rid of a couple of const_cast in TrkTrackSummaryTool

Trk::Track clarify changes due to const correctness in documentation. Get rid of a couple of const_cast in TrkTrackSummaryTool

Christos Anastopoulos authored 5 years ago and Walter Lampl committed 5 years ago

Add a type function for the different kind of Measurement Type, could help to avoid a few RTTI/dynamic_casts in client code

Address MR Feedback

In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment.  gcc9 now warns
about this by default.
Adjust to avoid the warning.

Susumu Oda authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Remove mutable from m_clusList of SpacePoint.h. Add ATLAS_CHECK_THREAD_SAFETY to InnerDetector/InDetRecEvent/SiSpacePoint.

In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment.  gcc9 now warns
about this by default.
Adjust to avoid the warning.

Additional packages used for compilation: InDetBeamSpotService, BeamSpotConditionsData, VxJetVertex and InDetTrackSelectorTool

Coverity issue# 113526.

Should result in fewer calls to the allocator and more data locality

cling erroneously aligns eigen objects to 8 bytes rather than 16 bytes.
This causes failures when accessing EDM objects via python/ROOT.
Add a couple alignment attributes to force cling to do the right thing.

This package contains the declaration:

   static const Amg::Vector2D INVALID_POSITION(INVALID,INVALID);

It appears, however, that when cling generates code for this
declaration, it does not respect the proper alignment --- we were
seeing this object 8-byte aligned, rather than 16-byte as eigen
requires.  This was causing ubsan warnings as well as assertion
failures from eigen.

This variable is, however, only referenced frmo two places in the same file,
and in those places we can just as well construct is as needed.
So get rid of this static.

Christos Anastopoulos authored 6 years ago and Adam Edward Barton committed 6 years ago

static thread checker for TrkParameters and TrkParametersBase, avoid const_cast and remove a static.

In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment.  gcc9 now warns
about this by default.
Adjust to avoid the warning.

Update references to headers moved from obsolete package CLIDSvc to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: 8df5cbaa

Update references to headers moved from obsolete package CLIDSvc to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: 6e44f164

Update references to headers moved from obsolete package CLIDSvc to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: 5282d389

Adjust for headers moved from CLIDSvc to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: 52c55a2d

Don't cache a null perigee pointer; leave the cache invalid in that case.
It can happen that the perigee is added after the TrkTrack is constructed.
(Using CachedPointer instead of CachedValue wouldn't have this issue...)



Former-commit-id: 7f579b87

Former-commit-id: b8a52766

move_ptr added.

Coverity issue# 113615


Former-commit-id: ae0ffe75

Former-commit-id: 97484f3b