cmake cleanup of the remaining (possibly obsolete) D3PDMaker packages.

Nils Krumnack authored 4 years ago and Nils Erik Krumnack committed 4 years ago

The two classes are functionally quite identical, so this is mostly a
straightforward string replacement, with a couple of manual fixes.

We no longer produce TAG files and these job options are obsolete.

Delete files related to TAG file making, i.e. "AttributesNames" headers
and the `TagFragmentCollection` class. The only class remaining is
`RawInfoSummaryForTag`.

Since Gaudi's StopperAlg is not available in the Athena runtime anymore.

Nils Erik Krumnack authored 4 years ago and Atlas Nightlybuild committed 4 years ago

AnalysisTop: Set random seed in MissingETObjectCollectionMaker

See merge request atlas/athena!38425

(cherry picked from commit 15902c8de9d399bc80c12b9bf8ebb2538a7c3ec2)

ce5b17b6 set random seed in MissingETObjectCollectionMaker

It is not entirely clear if this package is even useful anymore.
Nevertheless, delete some clearly obsolete files (they were not even
installed) and cleanup the remaining files.

D3PDs are no longer used for the inner detector. Besides, this packages
was already disabled in the build for a long time.

D3PDs are no longer used for background studies.

- delete unused `CheckD2PD` and `CreateControlPlots`
- delete all obsolete job options in `share/`
- remove obsolete flags in `D2PDFlags.py`
- delete unused `SUSYFilters.py`
- delete obsolete GRL from 2010
- cleanup cmake configuaration and enable flake8

There are some other unused "Selector" classes but kept those for
consistency with those that are still used in `AODSelect`.

TAG making is no longer supported.

TAG making ("doWriteTAG") is no longer supported and this package only
contains unused algorithms. Remove references from other packages to
this package or delete them entirely if obsolete.

The `EventTagGlobal.AttributeList` variable is still required in
RecExCommon. But in many other places we anyhow just use the hard-coded
value `"SimpleTag"`. So do the same here to avoid this trivial
dependency.

Remove `atlas_depends_on_subdirs` and tidy link dependencies.

Cleanup cmake configuration and remove unused GaudiKernel include.

Delete unused AddVarAlg+Tool, ParticleCombinerAlg+Tool,
ParticleSortingAlg+Tool. These depend on the deprecated `IJobOptionsSvc`
interface. If these algorithms turn out to be useful they can be
resurrected and migrated.

Also delete unused `MergeContainers.py` and cleanup cmake configuration.

Nils Erik Krumnack authored 4 years ago and Magnar Kopangen Bugge committed 4 years ago

21.2 MC truth classifier in MuonSelectorToolsTester

See merge request atlas/athena!38341

Nils Erik Krumnack authored 4 years ago and Atlas Nightlybuild committed 4 years ago

updated FTAG CDI file

See merge request atlas/athena!38380

(cherry picked from commit ddef6fcd34469096587eb25a476bbc4c1927d598)

2d4fb0a4 updated FTAG CDI file

Guillermo Nicolas Hamity authored 4 years ago and Adam Edward Barton committed 4 years ago

Fixing member variable ATLAS standard warning.

Remove `atlas_depends_on_subdirs` and fix link dependencies.

Rachid Mazini authored 4 years ago and Atlas Nightlybuild committed 4 years ago

New TFCSEnergyInterpolationPiecewiseLinear class for piecewise linear interpolation

See merge request atlas/athena!38095

(cherry picked from commit c591893349f43e8f913173aa9575045b6ef80aee)

dd0cab83 New TFCSEnergyInterpolationPiecewiseLinear class for piecewise linear interpolation
ffa9240b Made m_linInterpol direct class member
66fd9218 Made logEkin[] and response[] const

Nils Krumnack authored 4 years ago and Nils Erik Krumnack committed 4 years ago

This has been a long time coming, but one of the reasons for having
AsgMessaging as a separate package from AsgTools is to allow
xAODRootAccess to depend on it and use the same status codes and
messaging as the rest of analysis base.  This should take part of the
former.

I had to add the RECOVERABLE code to the main status code, but since
that is also part of the Gaudi StatusCode that seems like a reasonable
change/extension.

Apart from that this is mostly a global search replace to move all
users from TReturnCode to StatusCode, but apart from fixing up a
couple of places related to the status code itself I did not try to
fix/improve any code in the process.

Note that this also revealed a number of tests that failed because
they used RETURN_CHECK() incorrectly.  This commit doesn't try to
address that.