Mark Sutton authored 5 years ago and Adam Edward Barton committed 5 years ago

Currently TRT extension only enabled for the electrons. Turn this on by default,
allow oprion to disable if required

A few updates related to the event view creation for L2 combined muons:
- Use the ViewCreatorFetchFromViewROITool when creating teh event views to spawn views from the RoIs created by the L2 SA algorithm. This allows us to easily use the varying RoI sizes defined in the L2 SA algorithm, depending on where in the detector the muon is.
- Record the output of the ViewCreatorFetchFromViewROITool to the EDM, and remove the recording of the 'forID' RoI collection that was created inside the L2 SA views. Now the RoI collection is recorded at the event level to the EDM and can be used in the offline monitoring (as needed in ATR-20850)
- Fix a bug in the creation of the output RoI descriptor in ViewCreatorFetchFromViewROITool (need to create the new roi descriptor from the input RoI itself, and not the pointer)

Reverted commit d61df393 in order to assess issues in merge request for PRD caching and establish a setup which does not break frozen T0 policy

Updating the configuration of the track summary tools used in the muon trigger for the muon creation and ctrack cleaning so that we use the MuonTrackSummaryTool when building MS-only muons and have no ID tracks, and the combined muon track summary tool when we do have ID tracks. This fixes the warnings reported in ATR-20521.

Mark Sutton authored 5 years ago and Adam Edward Barton committed 5 years ago

The ID Trigger Track collections have been renamed using the new consistent
naming convention as discussed in the TGM of 2019-08-28 (https://indico.cern.ch/event/843886/)

https://indico.cern.ch/event/843886/contributions/3545029/attachments/1898633/3133218/sutt-idcollections-2019-08-28.pdf

This should include all the changes to the configuration of the ID Trigger
and the menu code for the signatures, including the signature monitoring.

The vertex collections still need to be renamed - this will be done in the
future once the track renaming is complete.

As pointed out in ATR-20706, we were adding collections to a view data verifier that already existed in a different data verifier running in the same views, so removing the duplication.

This reverts merge request !29397

Reecently a change to the track selection tool used in the muon triggers (in !29539) was introduced that drastically reduced the efficiency for finding combined muons. Switching back to the default muon specific track selector tool which has more appropriate cuts on ID tracks needed for muon reconstruction.

Adding in patches to remove the use of const_cast in the MDT RDO to PRD and to handle two RDO to one PRD special case

Removing the segment conversion algorithm from the ,uon trigger, since it turns out it isn't needed. Inorder to do this, also disabling the Track-Segment association done in the muon creator tool.
Fixes ATR-20781.

Addressing issues with the use of the caching in the CSC PRD. Added new decode functions which override the Core class

Laurynas Mince authored 5 years ago and Frank Winklmeier committed 5 years ago

Work in progress: added ID track histograms and monitoring for the inside-out and late muon reconstruction.

Importing the muon alignment configuration so that the alignment (and detector) conditions algorithms are properly added and configured when running offline trigger tests. Fixes ATR-20713.

Adding an ID container to our view data verifier to prevent a stall in the muon trigger (ATR-20524).

Updating the offline configuration of inside out muon reco algorithms and tools, and the muon creator algorithm and tools to be able to handle the trigger configuration.
Updating the trigger configuration to then use directly the offline configuration (plus a little bit of additional cleanup). Migration part of ATR-20389.

Trying to address some of the warnings about unmet dependencies coming from the muon trigger (ATR-20488).
- Allow the vertex container name to be empty for a couple of offline tools, and configure the trigger instances of the tools with the empty vertex conatiner (the muon trigger doesn't use the vertex information)
- Add the MuonSegmentCnvAlg to the trigger setup to produce the xAOD::Segments needed elsewhere
- Fix typo in the tag map name for the late muon configuration

Benjamin Michael Wynne authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Made view sequences with ID tracking algs sequential, to avoid loading intermediate data from FS sequences

Merging the offline and trigger configuration for the IndetCandidate and MuonCombined algorithms, and updating the trigger use case to follow the Run 2 configuration (ATR-20389).

   * The initial navigation collections produced by the L1Decoder are prefixed "HLTNav_" (like all other navigation collections)
   * The initial ROI and initial Rec ROI collections produced by the L1Decoder are prefixed "HLT_" (like all other persistifiable collections produced during HLT execution)
   * The white listing of ROI containers in the `recordable()` checking function is removed.
   * The white listing of "HLTNav_" containers in the `recordable()` checking function is changed to an ERROR.
   * All "HLTNav_" containers are added to the EDM (online) via TriggerConfig.py so they should never be specified by hand in TriggerEDMRun3.py
   * Added some missing navigation containers to the collection script (L1Decoder fullscan output and HLT summary maker output)
   * When exporting "HLTNav_", dynamic variables were removed. The output of HypoAlgs requires dynamic variables to re-map element links.
   * Both decObj and decObjFilterOut are now passed to triggerOutputCfg such that the sub-set in decObjFilterOut get the correct aux dyn added.

Savanna Shaw authored 5 years ago and Walter Lampl committed 5 years ago

Implementing the required configuration differences for the trigger to run the MS track building, track particle creation, and muon candidate building into the offline muon configuration, and changing the trigger to use the offline configuration directly (ATR-20389).