- Dec 16, 2020
-
-
- Dec 15, 2020
-
-
- Dec 14, 2020
-
-
scott snyder authored
Missing braces in if statement.
-
-
- Dec 12, 2020
-
-
Christos Anastopoulos authored
-
-
Christos Anastopoulos authored
STEPPropagator, the magnetic field returns double. So prb no reason to convert to float and the back implicitly to double
-
- Dec 11, 2020
-
-
Christos Anastopoulos authored
-
-
Christos Anastopoulos authored
GSF, move methods that do not need to be class member (i.e not use anything from this) to be in an anonymous namespace
-
- Dec 10, 2020
-
-
Christos Anastopoulos authored
-
scott snyder authored
CompactBinnedArray maps bins in some coordinates to a vector of pointers to objects. It does not own this objects. BinnedMaterial uses CompactBinnedArray, with the object in question being a pair<> object. When a BinnedMaterial is constructed, it takes a vector of pointers to these pairs. It does not take ownership of this pairs, but just passes them to the CompactBinnedArray. The callers of BinnedMaterial also do not take ownership of these pairs. So they are presently leaked. Further, BinnedMaterial can't just delete them, because these pairs get shared between multiple BinnedMaterial instances. We restructure like this. BinnnedMaterial now gets a vector of pairs, which it saves as a member. The CompactBinnedArray is then constructed to that it points at the pairs in this vector. BinnedMaterial now effectively owns the pairs. These are now duplicated in each BinnedMaterial, but that should be ok. We also need to extend CompactBinnedArray so that we can give it a new vector of object pointers when it is cloned. cf ATLASRECTS-5831.
-
scott snyder authored
CompactBinnedArray maps bins in some coordinates to a vector of pointers to objects. It does not own this objects. BinnedMaterial uses CompactBinnedArray, with the object in question being a pair<> object. When a BinnedMaterial is constructed, it takes a vector of pointers to these pairs. It does not take ownership of this pairs, but just passes them to the CompactBinnedArray. The callers of BinnedMaterial also do not take ownership of these pairs. So they are presently leaked. Further, BinnedMaterial can't just delete them, because these pairs get shared between multiple BinnedMaterial instances. We restructure like this. BinnnedMaterial now gets a vector of pairs, which it saves as a member. The CompactBinnedArray is then constructed to that it points at the pairs in this vector. BinnedMaterial now effectively owns the pairs. These are now duplicated in each BinnedMaterial, but that should be ok. We also need to extend CompactBinnedArray so that we can give it a new vector of object pointers when it is cloned. cf ATLASRECTS-5831.
-
- Dec 09, 2020
-
-
-
Walter Lampl authored
-
Walter Lampl authored
-
- Dec 08, 2020
-
-
scott snyder authored
Missing override keywords.
-
scott snyder authored
Unused private data member.
-
scott snyder authored
Missing override keyword.
-
Nicolas Köhler authored
-
Frank Winklmeier authored
-
scott snyder authored
Missing override keywords.
-
Christos Anastopoulos authored
ATLASRECTS-5829: IApprachDescriptor use unique_ptrs for the remaining ptr data member . See if fixes the reported memory leaks
-
- Dec 06, 2020
-
-
Christos Anastopoulos authored
-
- Dec 04, 2020
-
-
Christos Anastopoulos authored
TrackParticleCreator : EventContext aware . Also pass the EventContext from the EMBremCollectionBuilder
-
Andrii Verbytskyi authored
-
-
Frank Winklmeier authored
-
Frank Winklmeier authored
-
Frank Winklmeier authored
Remove uninformative success messages during initialize/finalize.
-
Andrii Verbytskyi authored
-
-
- Dec 03, 2020
-
-
-
-
Jon Burr authored
-
- Dec 02, 2020
-
-
Christos Anastopoulos authored
TrkGeometrySurfaces/TrkAlignableSurfaces move inline methods to separate icc, add override final where applicable possible
-
scott snyder authored
Don't declare PutTrackCollectionsInSG as a component. It's not needed, and duplicates one in TrkTrackCollectionMerger.
-
Christos Anastopoulos authored
TrkGeometrySurfaces/TrkAlignableSurfaces move inline methods to separate icc, add override final where applicable possible
-
- Dec 01, 2020
-
-
- Nov 30, 2020
-
-