Migrating the Muon RawDataProviders to use the Region Selector Tools instead of the old RegionSelectorSvc (ATR-22477), and updating the trigger configuration accordingly (the region selector is only needed in the seeded decoding used in the trigger).

Add a few explicit `str` conversions for DataHandles.

Removing some unnecessary objects from the muon view data verifiers (mostly objects that were being loaded that were not produced or used anywhere)

I don't think that the approach of modifying the class, rather than an instance, is a good idea.
I also worry that private tools are not being configured at all (specifically, the MdtCalibrationTool and MdtCalibrationDbTool). Attempting to fix this. This causes q431 changes, but this is probably expected.

Updating the muon InDetCandidateAlg to be able to skip using the InDetTrack selection tool, and updating the trigger configuration to not use apply the InDetTrack selection. It turns out that this cuts out quite a number of ID tracks, and does seem to have some impact on low pT muons.
Also added as mall change to initialise the ReadHandle for teh forward track particles only if it's actually needed.

Since we now run the decoding for the muon trigger directly inside the SA muon views, the related containers can be removed from the event view data verifier for this step.

Changing IDTrig signature configuration to contain both Fast & precision setting and implementing this to each signature

Since we use different RoIs when running the precision SA muon finding than we do for the fast SA muon finding, we need to run the decoding again in the muon precision muon RoIs. Otherwise we may miss hits that are included in the updated RoIs.

Since the isolation variables are no longer part of the muon EDM, we need to decorate teh muons with the isolation.

- Migrate the trigger muon isolation algorithm and isolation hypothesis alg/tool to use decoration handles for the isolation variables
-- Also slightly update the monitoring in the hypo tool (we only look at one muon at a time, so don't need to monitor vectors of variables)
- Updating slightly the event view creator algorithm to record the AuxContainer for the muons
- Adding the isolation variables in the EDM config
- Adjust the relevant parts of the trigger configuration to be compatable with the other changes

Scott Snyder authored 4 years ago and Walter Lampl committed 4 years ago

Do not add ConditionsStore entries to CondInputLoader.
It never did anything, and can be a symptom of a bad configuration,
so we want to make it an error.

Susumu Oda authored 4 years ago and Adam Edward Barton committed 4 years ago

Use IDCInDetBSErrContainer for SCT_FlaggedCondData instead of SCT_FlaggedCondData in WriteInDetESD.py

Adjusting the segment finding for the late muon triggers to use the NSW detectors if we are running with the NSW geometry. Should fix ATR-21830.

There were some lines in the configuration Python scripts that were
indirectly configuring the hole search tool, and this was causing
errors with the recent removal of properties from that tool. This
commit fixes some of these problems. I've done my best to look for any
more issues and fix them, but I can't really guarantee anything.

Explicitly loading event-level data into the muon trigger event views. Fixes the muon related failures in ATR-21685.

Chikuma Kato authored 4 years ago and Frank Winklmeier committed 4 years ago

This reverts commit 9846f7a703ae6c4bb80b98e3ac4ec9f4c765e8e4.

Just making the instances of RDOtoPRD decoding algorithms for the NSW detectors distinct so we don't run into interference issues in the future (probably the only reason it works OK now is that the seeded decoding isn't yet implemented). Also slightly updating the naming for the MM decoding to be consistent with the other technologies (which makes searching the log files easier).

Stewart Martin-Haugh authored 4 years ago and Adam Edward Barton committed 4 years ago

This reverts commit b99ef129.

Benjamin Michael Wynne authored 4 years ago and Frank Winklmeier committed 4 years ago

This reverts commit fabecdba85c3e2d0af3c9975280e6c35a7345283, reversing
changes made to 21adaed384d8892b49f40890eba46acc85329645.

Removing a few instances where we were defining a track particle container name (and also an algorithm name) globally within different muon sequences, which can cause problems depending on which order chains are configured in the menu (since the names were being overwritten). All the sequences that need the track particle collection name use the same default variable name that we define only once. All sequences that were changing the collection name did not have any later dependency on the new name in other sequences.