- useless comparison will nullptr
 - unused variables
 - typeid with side effects
 - string conversion

In the "new packaging" the external is now called like that...

The `TestPolicy` dependency stems mostly from the automatic `requirements`
to `CMakeLists.txt` file migration. In cmake builds, the TestPolicy
package is mostly useless apart from a few header files. So most
packages do no need this dependency anymore.

The changes belong to a large campaign aimed to clean up Athena code from incidents wherever possible.
These include:
  * Dropped redundant includes to FileIncident.h
  * Cleaned up all references to the UpdateOutputFile, BeginFile and EndFile incidents which are never fired
  * DecisionSvc cleaned up from the redundant inheritance from IIncidentListener
  * ByteStreamEventStorageInputSvc cleaned up from the redundant private service handle to IncidentSvc

These files exist in VP1UtilsBase as well, and make Ninja confused about
where to install the files from during the build. Since VP1UtilsBase seems
to be a "lower level" package, it seemed logical to keep the files in that
one.

Riccardo Maria Bianchi authored 5 years ago and Edward Moyse committed 5 years ago

fixed VP1 jO for NSW; fixed GeoFlags and JobConfig for NSW; fixed save/restore; added 'Misc.' checkboxes for sTGC and MM

Scott Snyder authored 5 years ago and Adam Edward Barton committed 5 years ago

Replace nonstandard _UNUSED macro with [[maybe_unused]].

Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

EventInfo had some const methods that were returning non-const pointers
to member data.  This violates the spirit of const-correctness
(and the thread-safety checker warns about it).
Clean up by splitting the affected methods into const and non-const versions,
returning const and non-const pointers, respectively.

Also dropped presampler ConstLink typedefs and migrated all clients to the new interface.

Dropped HEC and FCAL ConstLink typedefs and the redundant FCALHVDescriptor class

Migrated following client packages to the new interface of HEC and FCAL components of LArHV:
  LArCalorimeter/LArGeoModel/LArReadoutGeometry
  LArCalorimeter/LArGeoModel/LArGeoAlgsNV
  LArCalorimeter/LArGeoModel/LArGeoH62004Algs
  LArCalorimeter/LArCondUtils
  LArCalorimeter/LArCafJobs
  LArCalorimeter/LArRecUtils
  LArCalorimeter/LArG4/LArG4FCAL
  LArCalorimeter/LArG4/LArG4HEC
  Calorimeter/CaloCondPhysAlgs
  graphics/VP1/VP1Systems/VP1CaloReadoutSystems

Riccardo Maria Bianchi authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

DD changes for VP1Light/DumpGeo

all the new packages to dump/write/load/handle the persistent copy of the GeoModel

changes in VP1 packages for VP1Light

changes in Event/xAOD packages for VP1Light, especially for Ubuntu compilation

new Project to build VP1Light

adding Doxygen docs

moving TFPersistification to the new standalone GeoGenericFunctions

excluding StoreGate code when building VP1Light

adding a stub implementation for the missing compare method

moving to the new standalone Eigen-based GeoModelKernel and GeoGenericFunctions

fixing compilation errors, missing ROOT libraries

moving GeoWrite to new standalone, Eigen-based GeoModelKernel

clever C++11 way to silence the 'unused parameter' warnings

moving the last pieces to the new, standalone, and Eigen-based GeoModelKernel

fixing compilation issues when building VP1Light

using ATLAS-wide 'release-detection' algorithm, instead of my own custom one

added ubuntu instructions

Update top menu

update top menu

Update README.md

Update README.md

fixing build errors and warnings

fixing find GeoModel

fixing perigee access outside vp1light

fixing TFPersistification warnings

fixing GeoModelExamples warnings

fixing VP1Gui warnings

fixing RunVP1Light warnings

fixing GeoExporter warnings

fixing VP1GeometrySystems warnings

fixing VP1AODSystems warnings

removing a test: random_shuffle() has been removed in C++17 and should be replaced

Fixing STANDALONE compilation of xAOD and Trigger packages

Fixing VP1Light compilation of VP1 packages

removing image files from repo

Adding copyright and updating macOS instructions

Cleaning code, adding copyright, and removing old packages

Replacing BUILDVP1LIGHT with XAOD_STANDALONE

Cleaning.

Removed custom reference counting, dropped ConstLinks for Electrodes and Modules and
migrated clients to the new interfaces. Documented memory ownership implemented by
HV Managers, Modules and Electrodes.

The `AlgErrorAuditor` is obsolete. Remove its usage and the relevant
reconstruction flag (`rec.abortOnErrorMessage`).

The goal of this reorganization is to drop the dependency of the LArHV
package on custom reference counting mechanism implemented by GeoModelKernel/RCBase.
The latter mechanism is thread-unsafe and it is not really needed for LArHV.

As a first step of this reorganization, only EMBHV* classes have been modified.
The EMBHV*ConstLink typedefs have been dropped and the package clients have been
migrated to the new interface.

This is just to demonstrate how VP1 packages should be updated to make them
a bit more easy to use in downstream projects. (Like WorkDir.)

The default Gaudi `Incident` class now provides the same features as the
ATLAS specific `EventIncident`, i.e. the access to the EventContext.

Some of the VP1 packages were using the ${QT5_ROOT} variable. Since that
variable no longer exists, it seemed reasonable to clean up the configuration
of these packages. While at it, I made all other cleanup that seemed reasonable.

All units migrated except GeoModelKernelUnits::gram/g, which is different from Gaudi::Units::gram/g