Don't declare PutTrackCollectionsInSG as a component.
It's not needed, and duplicates one in TrkTrackCollectionMerger.

- Use new Gaudi helper class to iterate recursively through all child tools and using the new
  Gaudi visitor which renounces certain inputs from a tool, to renounce the output cluster splitting
  probability map from all child tools. The map is recorded to StoreGate before any of the child tools
  are called. Thus, the map, although not final yet, can already be used through read handles. Without
  renouncing the inputs, Gaudi would issue a circular dependency warning.
- Remove the previously introduced property which allowed to renounce manually the input cluster
  splitting probability map from the PixelClusterOnTrackTool.

Christos Anastopoulos authored 4 years ago and Adam Edward Barton committed 4 years ago

TrackSummary Tool, make Event context aware i.e add ability to pass EventContext from the caller and then propagate down the call chain

TrkGeometry Layers: Remove unneeded virtual methods.Also mark methods as final where applicable/possible

Remove unneeded / undefined EIGEN_INCLUDE_DIRS.

Stephen Nicholas Swatman authored 4 years ago and Adam Edward Barton committed 4 years ago

Currently, we're storing the charge value of the pattern track
parameters in a cached value, but this is not really necessary.
Computing the charge is so trivial and fast (from the q/p value) that
there really is no reason to cache this. We use the lazy binding
behaviour of the charge method to simply recompute on the fly.

Implement mungeZeroQOverP in terms of updateParameters , and SurfaceGetCovariance via a non-const method overload

The track extrapolation packages TrkExTools and TrkExUtils are related
to the pattern track parameters, but neither of these packages are
properly linked against the pattern track parameter packages. This
commit ensures that both of these packages are linked publicly against
the pattern parameters. This was not giving problems before - I'm not
exactly sure why, but I ran into linking problems with some changes to
the pattern code.

In my previous work to migrate the GlobalChi2Fitter to smart pointers, I
introduced a minor bug-prone bit of code where a smart pointer may be
used after being moved. While this has not been disasterous, it is still
erroneous behaviour that clang-tidy picks up on, as described in
ATLASRECTS-5738. This commit resolves the issue by keeping a non-unique
observer pointer to the object, and using that instead of the unique
handle which may be moved. This is mostly a quick fix, the method
containing this code is extremely complex and needs some refactoring.

Inconsistent function declarations.

Spurious copy in for loop.

 - Missing override keywords.