John Derek Chapman authored 5 years ago and Walter Lampl committed 5 years ago

This commit adds an `m_doNoise` configurable property to the
`FrontEndSimTool` base class. This is used to determine whether
or not the `ThermalNoise(...)` and `RandomNoise(...)` functions
should be called in the derived classes. This should replicate
the behaviour in `21.0` where the `PixelNoisyCellGenerator` is
only used when `digitizationFlags.doInDetNoise()==True`.

Former-commit-id: 5a775ae0

Soshi Tsuno authored 6 years ago and Walter Lampl committed 6 years ago

Former-commit-id: 27eaffd5

Former-commit-id: 04d0b012

Former-commit-id: d013975e

Former-commit-id: d1854ec4

The common geometry configuration stored in the Oracle table
"AtlasCommon" can only be accessed via InDetGMJobProperties as it
is implemented as properties of GeometryFlags which is member of
InDetGMFlags. Because the properties are (mostly) general (like
the run period) they should not be part of the ID only, but really
"common". It is already bad enough that the only specific field
in the table is called "STRIPGEOTYPE" ... On top, it turned out
that InDetGMJobProperties.py and LArGMJobProperties.py are quite
carbon copies of each other. These flaws are addressed in the
implementation of CommonGMJobProperties.py which provides access
to the common properties. Secondly it serves as base-class for the
classes in InDetGMJobProperties.py/LArGMJobProperties.py to reduce
code duplication. The modification is purely technical and should
not change anything. It passes the Tier0 tests. All clients should
be adjusted, but it was not possible to find test jobs for all of
them.


Former-commit-id: c79918fa

This reverts commit cdf718bf [formerly 9d67f5b8].


Former-commit-id: 008b62d0

This reverts commit 9156e32a [formerly f73d17d3], reversing
changes made to 27d106d1 [formerly 8f2f5188].


Former-commit-id: 9d67f5b8

Former-commit-id: 1ee19443

Former-commit-id: 37398d20

Former-commit-id: 166ef32d

Resolved the mmory issue (one of the containers, which would normally be cleared by going out of scope, had to be cleared manually). Still a difference in the output but I think that again this is becuase of the random number generaters. Will be debugging against old commit to check.


Former-commit-id: 3ff21edc

Former-commit-id: 0a0c4caa

Although there were no differences in the file outptu of the last commit, the run-time has slowed right down. I'm going to have to start over as it's not clear from debugging where the lag is coming from. I suspect its the EnergyDepSvc. Starting from a previouys commit and combining planar and DBM.


Former-commit-id: 429273c9

Former-commit-id: d06b0088

A new digiSteeringConf is required to configure digitization to write out SDOs
linked to Geantinos when in-time Geantino pile-up truth is saved. Fixes ATLASSIM-3193


Former-commit-id: 38915bd5

Former-commit-id: ba9523bd

Former-commit-id: e44822c3

Overlay jobs - see ATLASSIM-3240

The RDOCollNameSPM property had been removed in the C++, but not
in the python configuration used by Overlay jobs.


Former-commit-id: 02b19e3d

  * Replace ISiChargedDiodesProcessorTool with PixelProcessorTool.
	* Tagged as PixelDigitization-02-03-31.


Former-commit-id: c5aa163f

  * Fix coverity defect.
	* Tagged as PixelDigitization-02-03-30.

2017-02-10  Soshi Tsuno
  * Add front-end simulation tool.
  * Delete PixelCellDiscriminator. Now this functionality is done in front-end sim tool.
	* Tagged as PixelDigitization-02-03-29.


Former-commit-id: e12aa8ed

  * Small bug fix and remove warnings.
	* Tagged as PixelDigitization-02-03-28.

2017-01-30  Soshi Tsuno
  * Recover processBunchXing method for ATLASSIM-2900.
	* Tagged as PixelDigitization-02-03-27.

2016-12-26  Soshi Tsuno
  * The PixelDigitizationTool was largely cleaned up.
  * This is the preparation step toward ver.-03-00-00.
	* Tagged as PixelDigitization-02-03-26.

2016-12-25  Soshi Tsuno
  * remove SpecialPixelGenerator.
	* Tagged as PixelDigitization-02-03-25.

2016-12-21  Soshi Tsuno
  * Use ToolHandleArray for charge simulation (SurfaceChargeTool)
  * remove SurfaceChargeTool
	* Tagged as PixelDigitization-02-03-24.
...
(Long ChangeLog diff - truncated)


Former-commit-id: c9bf8664

  * Bug fix ATLASRECTS-3778.
	* Fix covarity checks.
	* Tagging PixelDigitization-02-03-23.


Former-commit-id: a87985ee

	* Fixing Random Genenrators for Bichsel model: ATLASRECTS-3738
	* Tagging PixelDigitization-02-03-22.

2016-11-19  scott snyder  <snyder@bnl.gov>
	* Tagging PixelDigitization-02-03-21.
	* endreq -> endmsg.

2016-11-17  John Chapman  <John.Chapman@cern.ch>

	* python/PixelDigitizationConfig.py (PixelOverlayDigitizationTool):
	Specify output StorGate instance for RDOCollNameSPM. ATLASSIM-3026
	* Tagged as PixelDigitization-02-03-20

2016-11-02  John Chapman  <John.Chapman@cern.ch>
	* python/PixelDigitizationConfig.py (PixelOverlayDigitizationTool):
	Specify output StoreGate instance in RDOCollName and SDOCollName
	properties - necessary now that these are configuring
	WriteHandles. obo Tatyana Kharlamova. ATLASSIM-3026
	* Taggged as PixelDigitization-02-03-19


Former-commit-id: 0ce3ed2d

  * bug fix : ATLPHYSVAL-430
  * Update SurfaceChargesTool to avoid initialization failure with Bichsel model on
  * Update PixelDigitizationConfig for fast version of Bichsel model
  * Tagged as PixelDigitization-02-03-18

2016-08-25 Soshi Tsuno
  * bug fix : ATLASRECTS-3444
  * Correct IBL configuration for 2016.


Former-commit-id: 8c1d238c

  * Changed the pixel setting to match with 2016 operation.
	* Tagged as PixelDigitization-02-03-15

2016-06-23 Fares Djama
        * Fix Jira ticket ATLASRECTS-3262 (fix cmt/requirement file)
	* Tagged as PixelDigitization-02-03-14

2016-06-23 Fares Djama
        * Fix Jira ticket ATLASRECTS-3294: get rid of hard coded limit in jumping over ganged pixels in FE-I3
	* Tagged as PixelDigitization-02-03-13

2016-06-23 Fares Djama
        * Fix Jira ticket ATLASRECTS-2925
        * Fix a bug in Initialization method of PixelNoisyGenerator
	* Tagged as PixelDigitization-02-03-12

2016-06-17 Fares Djama
        * Fixed the decoding of noisy map from pixid to (chip,col,row):
	*   1) IBL Compatible
	*   2) Uses a new decodePixelID method in PixelCoralClientUtils-00-05-09 to avoid hard coding
...
(Long ChangeLog diff - truncated)


Former-commit-id: e1673344

src/PixelDigitizationTool.h, src/PixelDigitizationTool.cxx: revert change from PixelDigitization-02-03-08 which switched processBunchXing back to using PileUpEventInfo rather than xAOD::EventInfo. Fix initialization order warning. PixelNoisyCellGenerator no longer needs to be a member variable. Fix issue where chargedDiodes variable name was both a member variable and an input variable name to a method. python/PixelDigitizationConfig.py (BasicPixelDigitizationTool): no need to specifically add to the ToolSvc. CfgGetter will take care of this. ATLASSIM-2565. Tagged as PixelDigitization-02-03-09 (PixelDigitization-02-03-09)

	* src/PixelDigitizationTool.h, src/PixelDigitizationTool.cxx:
	revert change from PixelDigitization-02-03-08 which switched
	processBunchXing back to using PileUpEventInfo rather than
	xAOD::EventInfo. Fix initialization order
	warning. PixelNoisyCellGenerator no longer needs to be a member
	variable. Fix issue where chargedDiodes variable name was both a
	member variable and an input variable name to a method.
	* python/PixelDigitizationConfig.py (BasicPixelDigitizationTool):
	no need to specifically add to the ToolSvc. CfgGetter will take
	care of this. ATLASSIM-2565
	* Tagged as PixelDigitization-02-03-09

2016-05-30 Sam Meehan
  * tagged revision 749595 as PixelDigitization-02-03-08

2016-05-27 Sam Meehan
  * tagged revision 749595 as PixelDigitization-02-03-07

2016-05-13 Soshi Tsuno
...
(Long ChangeLog diff - truncated)


Former-commit-id: d9bb100a

	* update the timing simulation for 2016.
	  src/TimeSvc.cxx .h: add new parameterization from 2015 collision data.
		src/PixelCellDiscriminator.cxx .h: default use 2015 timing.
	* update Bichsel model with improved execution time.
    src/BichselSimTool.cxx .h
		src/Ibl3DBichselChargeTool.cxx .h
		src/IblPlanarBichselChargeTool.cxx .h
		src/PixelBarrelBichselChargeTool.cxx .h
		src/PixelECBichselChargeTool.cxx .h
    share/Bichsel_1.dat _1_10steps.dat _1_5steps.dat
    share/Bichsel_2.dat _2_10steps.dat _2_5steps.dat
    share/Bichsel_3.dat _3_10steps.dat _3_5steps.dat
    share/Bichsel_4.dat _4_10steps.dat _4_5steps.dat
    share/Bichsel_5.dat _5_10steps.dat _5_5steps.dat
    share/Bichsel_6.dat _6_10steps.dat _6_5steps.dat

2016-04-05  John Chapman  <John.Chapman@cern.ch>

	* src/BichselSimTool.cxx (BichselSim): comment out unused
...
(Long ChangeLog diff - truncated)

src/Ibl3DBichselChargeTool.cxx (Ibl3DBichselChargeTool): reorder initialization of member variables to remove build warning. (charge): comment out unused m_isRealBichsel variable to get rid of build warning. Tagged as PixelDigitization-02-00-20-04 (PixelDigitization-02-00-20-04)

	* src/Ibl3DBichselChargeTool.cxx (Ibl3DBichselChargeTool): reorder
	initialization of member variables to remove build warning.
	(charge): comment out unused m_isRealBichsel variable to get rid
	of build warning.
	* Tagged as PixelDigitization-02-00-20-04

2016-03-23 Magda Chelstowska <magdac@cern.ch>
	* Fixed Pixel Cabling for Run1 digi (obo John Chapman) ATLASSIM-2680
	* Tagged as PixelDigitization-02-00-20-03

2016-02-17  John Chapman  <John.Chapman@cern.ch>
	* Revert changes from PixelDigitization-02-00-20-01
	* Merge in changes from PixelDigitization-02-00-22-04 without the
	changes from PixelDigitization-02-00-21. ATLASSIM-2593
        * Set doITk flags consistently using GeometryFlags.isSLHC()
        * SurfaceChargeTool: Use IBL planar modules everywhere if doITk
	for now
        * Added more debug statements
        * src/PixelDigitizationTool.cxx - Use "at" to protect against
...
(Long ChangeLog diff - truncated)

	* Set default value of latency in B layer to 150
	* tagged as PixelDigitization-02-00-20

	* Correct test when not to use the offline calib svc.

2015-11-03 Goetz Gaycken
	* Allow to run without an offline calib svc. This wil set the
	  IBL overflow value to the maximum of 16.

2015-11-03 Silvia Miglioranzi <silviam@mail.cern.ch>
	* src/Ibl3DChargeTool.cxx
	fix the correct granularity for the IBL3d charge probability map
	* tagged as PixelDigitization-02-00-17

2015-10-23 Fares Djama
	* HitDiscCnfg read from COOL folder /PIXEL/HitDiscCnfg
	* tagged as PixelDigitization-02-00-16

2015-10-12  John Chapman  <John.Chapman@cern.ch>

	* python/PixelDigitizationConfig.py -
	PixelOverlayDigitizationTool: use overlay flags to set
	EvtStore. ATLASSIM-1922.
...
(Long ChangeLog diff - truncated)