Enable thread-safety checking.
Fix identified issues.
Also more constness fixes.

Use conditions data in converters rather than relying on obsolete tools.
Make pointers to block structure objects slot-specific.

LArSimEventTPCnv_HITS - passes

LArTPCnv_15.6.7_test - passes (updated reference file)
LArTPCnv_20.1.7.2_test - passes

Working towards getting this package to pass the thread-safety checker.

Remove static members from LArRodEncoder; instead, pass in the helper objects
to its ctor.  Change it to use conditions data rather than then old
legacy cabling service.

Hid2RESrcID depends on the old, thread-unsafe LArCablingLegacyService.

We can't get rid of it completely, because it's required by interfaces
still used by TrigT2CaloCommon.

Refactor so that it won't affect the thread-safety of the rest of this package.

Split out the part of Hid2RESrcID required by FullEventAssembler into
a separate base class RodRobIdMap.

Split the remaining interfaces of Hid2RESrcID into thread-safe and
thread-unsafe versions.  Only the thread-safe functionality will be needed
from this package; the thread-unsafe versions are needed only
by TrigT2CaloCommon.

Don't use exit().
Remove some const_cast / mutable.
Make static data const.

    
Make references to CaloCellCorrection instances const.

Get rid of the member variables LArRodDecoder::m_rodFrag and m_error,
as a step toward making the LArRodDecoder methods const.

The new data handle property type requires explicit `str` conversion.

 - Prefer pre-increment (or range-for) to postincrement.
 - Use unions rather than type punning.
 

Use AthConstConverter as the base class for the BS converters in this class.
Make things properly const + further cleanups.

Change from ICaloNoiseTool to CaloNoise conditions data.

Delete unused `LArCalorimeter/LArSim` package and files referencing it.

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

Add reference for LArLATOMEHeaderContainerCnv_p1_test.

Remove `atlas_depends_on_subdirs` and cleanup link dependencies.

Missing override keywords.

Mismatched include guard.

Pavol Strizenec authored 4 years ago and Walter Lampl committed 4 years ago

Add ATLAS_CHECK_THREAD_SAFETY to InDetBeamSpotService package to check and keep thread safety. Add ATLAS_NOT_THREAD_SAFE of CxxUtils/checker_macros.h to BeamCondSvc::initialize and BeamCondSvc::fillRec because these use thread unsafe AthenaAttributeList::AthenaAttributeList and StoreGateSvc::regFcn.

Pass large objects by const reference, not by value.

SealSvc does not have any useful function any more

Frank Berghaus authored 4 years ago and Walter Lampl committed 4 years ago

The ByteStreamEventStorageInput service provided a legacy job option called FullFileName to specify bytestream input. With the move to EventSelector this option was all but removed from ByteStreamEventInputSvc. The EventSelectorByteStream provieded the input option to specify input. It captured the FullFileName option of the InputSvc. This commit removes the relevant parts of the ByteStreamEventStorageInputSvc and EventSelectorByteStream. It also attempts to move all references in other job options (unless they specify being for an older release).

    
Tweak the lcgdict patterns for pairs, for compatibility with gcc10/root 6.20.
We need to get the __pair_base template if it exists (but we don't want
to explicitly mention it).  We also need to avoid matching various internal
STL traits classes templated on pairs.

If we check for an error condition and the check fails, we should't continue.

Here, the checks were for internal logic problems, so change them to assert.

That variable will be set on the project level in the future, the packages
should not bother setting it themselves.