Change to range-based for.

Change to range-based for.

Change to range-based for.

Change to range-based for.

    
Change to range-based for.

    
Change to range-based for.

    
Change to range-based for.

    
Change to range-based for.

    
Change to range-based for.

Change to range-based for.

Fix compilation with python 3.

Fix compilation with python 3.

Fix compilation with python 3.

The methods dropped:
  AsgMetadataTool::retrieveMetadata()
  TEvent::retrieveIOVMetadata()

Also added a missing dependency on AthenaPoolUtilities to MuonByteStream,
and a missing dependency on RootUtils to TrigOutputHandling

Use range-based for instead.

Force use of in-file trigger metadata when reading MT AOD in the R2 legacy PhysicsValidation AOD->NTUP_PHYSVAL transform

The `beginRun` method is deprecated. One-time initializations before the event loop
need to be done in `start`.

The `beginRun` method is deprecated. One-time initializations before the event loop
need to be done in `start`.

Types for m_maxDeltaR and m_minPt seemed wrong --- they were used
as floats, but declared as bool.

 - Shadowing of member names between base and derived classes.
 - std::string should be passed by const reference, not value.
 - Prefer initializing members in init clauses.
 

Emmanuel Le Guirriec authored 5 years ago and Edward Moyse committed 5 years ago

first try to btag one jet collection twice (two trainings)

Prefer preincrement to postincrement for iterators.

Susumu Oda authored 5 years ago and Adam Edward Barton committed 5 years ago

Replace used PixelConditionsSummarySvc by PixelConditionsSummaryTool and remove unused PixelConditionsSummarySvc.

Joerg Stelzer authored 5 years ago and Adam Edward Barton committed 5 years ago

Apply suggestion to Trigger/TrigConfiguration/TrigConfInterfaces/TrigConfInterfaces/ITrigConfigSvc.h

Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Rework to remove use of non-standard #define private.

Also make TP converter interfaces const.

Scott Snyder authored 5 years ago and Walter Lampl committed 5 years ago

Change pool converters to use the templated versions.

Some extensions to avoid #define private in converters.