- fix external dependencies
- update link dependencies
- remove `atlas_depends_on_subdirs`

Cleanup of cmake configuration of GeoModel related packages. Tidy
external and links dependencies. Remove `atlas_depends_on_subdirs`.

Also adapting derived classes `DefaultAGDDTool`, `MuonAGDDTool` and `NSWAGDDTool`
to use `Gaudi::Property` member variables from the base-class correctly.

Delete the unused RegSel*LUTCondData classes (ATR-21807) to avoid a
cyclic dependency on the RegionSelector library/package.

Also cleanup the cmake configuration.

Frank Winklmeier authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

- remove unused Eigen dependency
- do not install headers that are not used outside this package

- remove unused ROOT dependency
- no need to install dictionary header
- enable thread checker

- cmake cleanup
- enable flake8
- delete obsolete `DetStore.py` job options

- remove atlas_depends_on_subdirs
- remove unused ROOT dependency

Remove unused CORAL/Boost dependencies. Cleanup cmake configuration and
delete unused `Load_IdDictCnvTest_joboptions.py`. Enable thread checker.

Cleanup configuration, remove unused ROOT and boost dependency.

Cleanup cmake configuration and delete deprecated
RegionSelector_jobOptions.py.

There is already a library that provides the public headers and hence
the `atlas_install_headers` is redundant.

The list of affected packages:
 * DetectorDescription/GeoModel/GeoModelExamples
 * DetectorDescription/GeoModel/GeoModelSvc
 * DetectorDescription/GeoModel/GeoModelUtilities
 * DetectorDescription/GeoModel/GeoSpecialShapes

If a dtor is declared final, the class itself should also be declared final.

1. Cleaned CMakeLists.txt in several LArGeoModel packages by dropping atlas_depends_on_subdirs(),
and dropping redundant dependencies on BOOST and CORAL

2. Dropped redundant GeoModelUtilities/LArCustomShape.h

GeoModelUtilities: Compile GeoVisitVolumes::handleSerialTransformer with optimization, even in debug builds.

GeoVisitVolumes::handleSerialTransformer makes heavy use of Eigen.
We tend to spend a lot of time there in debug builds, where the performance
of Eigen is very poor.  So force this function to be compiled with optimization,
even in debug builds.  This speeds up some tests significantly.

We spend a lot of time in IdDictDictionary::unpack in debug builds
(mostly called from the Csc conditions code).  So force this function
to be compiled with optimization, even in debug builds.
This speeds up some tests by 20-30%.

Savanna Shaw authored 4 years ago and Edward Moyse committed 4 years ago

Migrating the MuonSegmentRegionRecoveryTool to use the new region selector tools instead of the region selector service:

- Extend the new JO configuration for the region selector tools to include the rest of the muon technologies
- Update the segment region recovery tool to use the region selector tools instead of the old servic
- Update the configuration for the segment region recovery (both old and new style JOs)
- We were always configuring the MuonSegmentRegionRecoveryTool due to the 'getPublicTool' call in MooreTools.py. This caused some issues with scheduling the region selector cond alg out of place in the legacy trigger tests. In the end this 'getPublicTool' call is not needed, since the tools are all configured in the relevent places, so have removed it.

Fixes ATLASRECTS-5377.

SealSvc does not have any useful function any more

Add ATLAS_CHECK_THREAD_SAFETY to InDetRegionSelector and MuonRegionSelector packages with removing const from getLUT()

HITS test has been timing out frequently in the dbg build.

In the muon subsystem checks is_rpc, etc, we first need to ensure
that is_muon passes.  Otherwise, we can crash if called for
a non-muon identifier.

When we initialize an Identifier from a 32-bit value, make sure
to preserve invalid values.  We were just shifting left by 32 bits,
which means that the invalid 0xffffffff becomes 0xffffffff00000000,
for which is_valid() returns true.  This was causing us not to detect
some invalid identifiers after they were saved and reloaded.