Skip to content
Snippets Groups Projects
  1. Jan 21, 2019
    • Charles Burton's avatar
      resolve MR comments · b51fdfb3
      Charles Burton authored
      1. Cleanup boilerplate code
      2. Change property declaration to new method
      3. Change function names in AthMonitorCfgHelper
      4. Add AOD to TestDefaults.py
      5. Add override keyword to functions
      b51fdfb3
  2. Jan 16, 2019
  3. Jan 15, 2019
  4. Jan 14, 2019
    • Frank Winklmeier's avatar
      AthenaMonitoring: improve test coverage and cleanup · 47e3ac78
      Frank Winklmeier authored
      - `HistogramDef`: fix a parsing bug where the histogram definition
        string had to end with a trailing comma for 1D histograms without
        labels and options.
      - Remove the trailing comma produced by `defineHistogram`
      - Adapt the existing C++ unit tests and add a test for `TProfile2D`
      - Deprecate the use of "label1:label2" syntax in `defineHistogram`
      - Add a unit test for the `defineHistogram` method
      - Change line endings from DOS to UNIX in source files
      47e3ac78
    • Frank Winklmeier's avatar
      Fixes for standalone compilation · 5bc0430a
      Frank Winklmeier authored
      Make some trivial code changes to make it possible to compile some of
      the Monitored classes outside of athena:
      - Rely on explicit StatusCode->bool conversion instead of calling
        isFailure()
      - Add missing include files
      
      In addition, remove `std` import and change line endings from DOS to
      UNIX.
      5bc0430a
  5. Jan 13, 2019
  6. Jan 11, 2019
  7. Jan 10, 2019
  8. Jan 08, 2019
  9. Jan 07, 2019
  10. Jan 06, 2019
    • Scott Snyder's avatar
      AthenaKernel: Fix gcc9 warnings. · af8d2118
      Scott Snyder authored
      In C++11, implicit declarations of copy and assignment are deprecated if the
      class has a user defined destructor or copy or assignment.  gcc9 now warns
      about this by default.
      Adjust to avoid the warning.
      af8d2118
    • scott snyder's avatar
      CxxUtils: Fix potential race in ConcurrentRangeMap::trim(). · b6d89d41
      scott snyder authored
      When finishing the trim() operation, the begin pointer must be updated
      before queuing the dummy impl object for discard.  Otherwise, another thread
      could potentially see a pointer to a deleted object.
      
      Trying to fix infrequent crashes in CondCont_test observed in nightlies and CI.
      b6d89d41
  11. Jan 03, 2019
  12. Jan 02, 2019
  13. Dec 27, 2018
  14. Dec 26, 2018
  15. Dec 23, 2018
  16. Dec 21, 2018
  17. Dec 20, 2018
  18. Dec 18, 2018
Loading