This reverts commit 6d8c8624 [formerly 8650a859].


Former-commit-id: bac9f4d6

Former-commit-id: 8650a859

Remove references to obsolete package DataModel.
Also remove references to CLIDSvc and SGTools.



Former-commit-id: df6e02e0

Headers in this package are not used from any other package.
Move those to src.


Former-commit-id: dcf4b341

CaloCellCorrection methods are const.

CaloCellCorrection::MakeCorrection is now const, with an EventContext argument.
Adjust uses of it.
Working to make more of the calorimeter reconstruction reentrant.

Former-commit-id: c4b71645

major changes:

 - removal of DECLARE_FACTORY_ENTRIES
 - DECLARE_CONVERTER_FACTORY -> DECLARE_CONVERTER
 - DECLARE_TOOL_FACTORY -> DECLARE_COMPONENT
 - DECLARE_SERVICE_FACTORY -> DECLARE_COMPONENT
 - DECLARE_ALGORITHM_FACTORY -> DECLARE_COMPONENT
 - constructor of Converters is public, not protected
 - remove #include "GaudiKernel/CnvFactory.h"
 - remove #include "GaudiKernel/ToolFactory.h"
 - remove #include "GaudiKernel/AlgFactory.h"
 - remove #include "GaudiKernel/AudFactory.h"
 - remove #include "DeclareFactoryEntries.h"


Former-commit-id: fd7a40f5

@srettie spotted some lines in the muon code which ended with
two semicolons. As there is no convincing answer, they were
changed to single semicolons - and not only in muon code,
but throughout the repository (except generator packages).


Former-commit-id: 317d8317

Former-commit-id: 9b39c6d9

gcc8 warnings: catching polymorphic exceptions via value.


Former-commit-id: f65782f0

gcc8 warnings: catching polymorphic exceptions via value.


Former-commit-id: 22a43330

Remove references to obsolete package DataModel.



Former-commit-id: 9ad680a5

This reverts commit cdf718bf [formerly 9d67f5b8].


Former-commit-id: 008b62d0

Use the proper return type instead of relying on StatusCode/bool
conversions.


Former-commit-id: 292c3c6b

This reverts commit 9156e32a [formerly f73d17d3], reversing
changes made to 27d106d1 [formerly 8f2f5188].


Former-commit-id: 9d67f5b8

Explicitly specify the CHECK macro return value (0 or false) for methods returning
an int/bool instead of relying on the implicit StatusCode conversion.


Former-commit-id: c15ca7ed

CLASS_DEF.h moved from CLIDSvc to AthenaKernel.



Former-commit-id: 8a5ddc55

Compilation warnings: uninitialized variables.



Former-commit-id: cd127434

Compilation warning: uninitialized variable.



Former-commit-id: 668f4ddc

Compilation warning: uninitialized variable.



Former-commit-id: 15256a1f

Remove cmt directories that contain trivial, obsolete content.


Former-commit-id: c24266ed

A few constructors had to be made public as required by the Gaudi Plugin
service.


Former-commit-id: b88be914

- Delete all obsolete src/components/*_load.cxx files
- Remove obsolete DECLARE_FACTORY_ENTRIES within
  src/components/*_entries.cxx

The removed macros evaluate to NULL on the Gaudi side and have been
kept only for backwards compatibility.


Former-commit-id: b54b335b

remove duplicate (obsolete) copyright statements of the form Copyright (C) 2003 by ATLAS Collaboration


Former-commit-id: 68f0d5d4

Remove reference to deprecated Gaudi header PropertyMgr.h
(and a few other unused ones).


Former-commit-id: 2cfc1a91

Former-commit-id: 9b3385a5

Former-commit-id: fe11edea

endreq is deprecated, and replaced with endmsg.

Did not replace in log files, or READMEs. Two files which are questionable are
   InnerDetector/InDetAlignAlgs/InDetAlignGenAlgs/src/GeoModelTRT.dev
and
   InnerDetector/InDetRecTools/InDetMultipleVertexSeedFinderUtils/src/PVFindingTrackFilter_cxx


Former-commit-id: 699dba0d

	* Tagging TBDetDescrAlg-00-00-07.
	* Avoid gcc7 switch fallthrough warnings.


Former-commit-id: ee3c7830

        * Tagging TBRec-00-06-24.
	* Tool handle constness fix.

2016-08-01  scott snyder  <snyder@bnl.gov>

        * Tagging TBRec-00-06-23.
	* Use ATH_MSG macros.

2016-07-27  scott snyder  <snyder@bnl.gov>

        * Tagging TBRec-00-06-22.
	* endreq -> endmsg.

2016-07-21  scott snyder  <snyder@bnl.gov>

        * Tagging TBRec-00-06-21.
	* Const fixes.

2016-06-25  scott snyder  <snyder@bnl.gov>
...
(Long ChangeLog diff - truncated)


Former-commit-id: 9cbd6bf7

	* Tagging TBMonitoring-00-02-12.
	* Coverity 109049.

2016-07-28  scott snyder  <snyder@bnl.gov>

	* Tagging TBMonitoring-00-02-11.
	* endreq -> endmsg.
	* Tagging TBMonitoring-00-02-10.
	* Const fixes.

2016-06-30  scott snyder  <snyder@bnl.gov>

	* Tagging TBMonitoring-00-02-09.
	* LArCablingService moved from LArTools to LArCabling.
	* Tagging TBMonitoring-00-02-08.
	* Avoid FP division by constants.
	* Tagging TBMonitoring-00-02-07.
	* Fix duplicate property warnings.
	* Tagging TBMonitoring-00-02-06.
...
(Long ChangeLog diff - truncated)


Former-commit-id: cedd47f5

	* Tagging TBDetDescrCnv-00-02-01.
	* endreq -> endmsg.


Former-commit-id: 40645727

	* Tagging TBEventAthenaPool-00-01-03.
	* endreq -> endmsg.  messageService -> msgSvc.


Former-commit-id: 40b49da7

	* Tagging TBDetDescr-00-01-01.
	* endreq -> endmsg.


Former-commit-id: bf398146

	* Tagging TBCnv-00-03-29.
	* Remove references to messageService().

2016-07-27  scott snyder  <snyder@bnl.gov>

	* Tagging TBCnv-00-03-28.
	* endreq -> endmsg.

	* Tagging TBCnv-00-03-27.
	* Const fix.

2016-07-09  scott snyder  <snyder@bnl.gov>

	* Tagging TBCnv-00-03-26.
	* src/TBByteStreamCnvTool.cxx: Fix gcc6 indentation warnings.


Former-commit-id: a365b08d

	* Tagging TBCaloGeometry-00-01-05.
	* Const fix.


Former-commit-id: 9982c4b7

2016-06-23 Attila Krasznahorkay <Attila.Krasznahorkay@cern.ch>
	* Making the package link against the necessary tdaq-common
	  libraries. To make it possible to turn on using -Wl,--no-undefined
	  in the build.
	* Removed the executable flag from all of the files in the package.
	* Tagging as TBCnv-00-03-25


Former-commit-id: 5b7ca15de92a84cd22cc1d24330b125f7d48acff

'Coverity 108621, 108907, 108928, 108933, 108940, 108946, 108947, 108949, 108950, 108951: uninitialized members.' (TBRec-00-06-16)

        * Tagging TBRec-00-06-16.
	* Coverity 108621, 108907, 108928, 108933, 108940, 108946, 108947,
	108949, 108950, 108951: uninitialized members.


Former-commit-id: c5380141

        * Tagging TBEvent-00-02-39.
	* Fix cppcheck warnings.

2016-03-10  scott snyder  <snyder@bnl.gov>

        * Tagging TBEvent-00-02-38.
	* Add a few more accessors.

2015-03-12  scott snyder  <snyder@bnl.gov>

        * Tagging TBEvent-00-02-37.
	* Coverity warning fixes.

        * Tagging TBUtils-00-00-08.
	* TBUtils/TBProfiler.icc: Fix coverity warning.

2015-02-17  scott snyder  <snyder@bnl.gov>

        * Tagging TBUtils-00-00-07.
	* Fix coverity warnings.

        * Tagging TBUtils-00-00-06.
	* TBUtils/TBProfiler.icc: Fix clang warnings.

        * Tagging TBRec-00-06-15.
	* Coverity warnings 105587, 105761.

2016-03-09  scott snyder  <snyder@bnl.gov>

        * Tagging TBRec-00-06-14.
	* Avoid repeated division and division by constants.
        * Tagging TBRec-00-06-13.
	* Comply with ATLAS naming conventions.
        * Tagging TBRec-00-06-12.
	* Remove obsolete #includes (fix compilation with clang).
	* Remove #define private.

2015-05-01  scott snyder  <snyder@bnl.gov>

        * Tagging TBRec-00-06-11.
	* src/TBEMECXTalkToyModel.cxx: More coverity warnings.

2015-04-06  scott snyder  <snyder@bnl.gov>
...
(Long ChangeLog diff - truncated)