Frank Berghaus authored 4 years ago and Walter Lampl committed 4 years ago

Setting multiple streams to write to the same file causes problems when
there is an overlap in the streams' metadata itemlists that is not
1-to-1: those items in the overlap will add more entries to the metadata
tree than the others causing a failure when attempting to close the file
after writing. If the list is 1-to-1 overlapping the metadata tree has
multiple entries, which may lead to undefined behaviour.

There is no reason to expect multiple output streams to need to write to
the same file. We do not support that configuration, and should not test
for it.

Fix test failures in master.

Partially addresses ATEAM-677

Add release number to ignore patterns in reference file comparison.

- Define simply tests directly via the `SCRIPT` command rather than
  having a wrapper shell script.
- Delete unused `.ref` files and scripts.

Major cleanup of the unit test definition:
- Use official `post.sh` script for reference comparison
- Fix test dependencies. Previously all tests were run sequentially. In
  principle there could be a problem when multiple jobs try to write to
  the same PoolCatalog. If that happens we may need to define separate
  run directories for each test.
- Copy all references to git to avoid the awkward EOS copy. Some of the
  references are a few 100kB, however, they compress to almost nothing
  so this should not be an issue for git storage.
- Delete all obsolete test scripts.
- Fix a few mistakes in job options that the previous post-processing
  script missed.

Update test references due to Gaudi tool auto-retrieval (!37533).

Ignore auto-retrieve INFO message introduced in gaudi/Gaudi!1124.

Marcin Nowak authored 4 years ago and Edward Moyse committed 4 years ago

Trying to group access to TagInfo object exclusively to the
TagInfoMgr so it can be better managed during input file transitions
in MT

Remove reference to obsolete header StoreGate.h.

Remove reference to obsolete header StoreGate.h.

Frank Berghaus authored 4 years ago and Adam Edward Barton committed 4 years ago

This has just laid dormant ever since the CMT->CMake migration. :-(

At the same time introduced some tests for the implicit copy-constructor
and copy-operator of xAOD::EventFormat.

Prior to this change log file diffs in unit tests compared the reference file to the current
output, rather than the other way around, so that lines in the log removed due to local
changes are marked with a `+` in the diff output and lines added to the log are marked with
a `-`.

This commit switches the order of comparison with the aim of making the output more intuitive.
See discussion in ATEAM-644.

For TagInfo changes.

Fixed most of the ctest failures introduced by !35242

- remove atlas_depends_on_subdirs
- update link and external dependencies

- remove ROOT dependency
- remove atlas_depends_on_subdirs
- update link dependencies

With athenaMT it is best to rely on the default (ROOT) signal handler in
CoreDumpSvc, which uses gdb to produce the stacktrace for all threads.
Setting `FatalHandler = 438` makes use of the `SealSignal` handler,
which only produces one trace. For production environments where the gdb
traces are not needed, one should override the setting in the transform
or AMI tag as is already done today.

Relates to ATEAM-629.

Use explict cast for int->float conversion that loses precision.

Fix test failures in master.

SealSvc does not have any useful function any more