Missing override keywords,

Move detector-specific code to read the geometry database into
standalone "[Det]GeoDB.py" modules. Use this code both in the old
jobproperties as well as in the new-style `AutoConfigFlags` to avoid the
copy&paste of the same code.

Also fix the caching of `AutoConfigFlags.GetDetDescrInfo` to make sure the
geometry DB is only queried once per geometry tag.

Andrea Dell'Acqua authored 4 years ago and Walter Lampl committed 4 years ago

Main changes:
- introduction of new shape (simplepolygonbrep)
- unification of messaging code, with the introduction of an OutputDirector
- consistent utilization of XMLString::transcode() throughout the code
new files:
	GeoModelXml/OutputDirector.h
	GeoModelXml/shape/MakeSimplePolygonBrep.h
	src/MakeSimplePolygonBrep.cxx
deleted file:
	GeoModelXml/translate.h
Please note that data/geomodel.dtd (needed at run time) was modified according to the simplepolygonbrep introduction)
List of modified files (basically all of them!) follows:

	modified:   GeoModelXml/AddbranchProcessor.h
	modified:   GeoModelXml/AssemblyProcessor.h
	modified:   GeoModelXml/AssemblyrefProcessor.h
	modified:   GeoModelXml/Element2GeoItem.h
	modified:   GeoModelXml/ElementProcessor.h
	modified:   GeoModelXml/Gmx2Geo.h
	modified:   GeoModelXml/GmxUtil.h
	modified:   GeoModelXml/IndexProcessor.h
	modified:   GeoModelXml/LogvolProcessor.h
	modified:   GeoModelXml/LogvolrefProcessor.h
	modified:   GeoModelXml/MakeElement.h
	modified:   GeoModelXml/MakeMaterial.h
	modified:   GeoModelXml/MakeRotation.h
	modified:   GeoModelXml/MakeTransformation.h
	modified:   GeoModelXml/MakeTransformationref.h
	modified:   GeoModelXml/MakeTranslation.h
	modified:   GeoModelXml/MulticopyProcessor.h
	modified:   GeoModelXml/StrictErrorHandler.h
	modified:   GeoModelXml/TransformProcessor.h
	modified:   GeoModelXml/TransformrefProcessor.h
	modified:   GeoModelXml/createdomdocument.h
	modified:   GeoModelXml/shape/AddPlane.h
	modified:   GeoModelXml/shape/MakeBox.h
	modified:   GeoModelXml/shape/MakeCons.h
	modified:   GeoModelXml/shape/MakeGenericTrap.h
	modified:   GeoModelXml/shape/MakeIntersection.h
	modified:   GeoModelXml/shape/MakePara.h
	modified:   GeoModelXml/shape/MakePcon.h
	modified:   GeoModelXml/shape/MakePgon.h
	modified:   GeoModelXml/shape/MakeShaperef.h
	modified:   GeoModelXml/shape/MakeSubtraction.h
	modified:   GeoModelXml/shape/MakeTrap.h
	modified:   GeoModelXml/shape/MakeTrd.h
	modified:   GeoModelXml/shape/MakeTube.h
	modified:   GeoModelXml/shape/MakeTubs.h
	modified:   GeoModelXml/shape/MakeUnion.h
	modified:   data/geomodel.dtd
	modified:   src/AddPlane.cxx
	modified:   src/AddbranchProcessor.cxx
	modified:   src/AssemblyProcessor.cxx
	modified:   src/AssemblyrefProcessor.cxx
	modified:   src/Element2GeoItem.cxx
	modified:   src/ElementProcessor.cxx
	modified:   src/Gmx2Geo.cxx
	modified:   src/GmxInterface.cxx
	modified:   src/GmxUtil.cxx
	modified:   src/IndexProcessor.cxx
	modified:   src/LogvolProcessor.cxx
	modified:   src/LogvolrefProcessor.cxx
	modified:   src/MakeBox.cxx
	modified:   src/MakeCons.cxx
	modified:   src/MakeElement.cxx
	modified:   src/MakeGenericTrap.cxx
	modified:   src/MakeIntersection.cxx
	modified:   src/MakeMaterial.cxx
	modified:   src/MakePara.cxx
	modified:   src/MakePcon.cxx
	modified:   src/MakePgon.cxx
	modified:   src/MakeRotation.cxx
	modified:   src/MakeShaperef.cxx
	modified:   src/MakeSubtraction.cxx
	modified:   src/MakeTransformation.cxx
	modified:   src/MakeTransformationref.cxx
	modified:   src/MakeTranslation.cxx
	modified:   src/MakeTrap.cxx
	modified:   src/MakeTrd.cxx
	modified:   src/MakeTube.cxx
	modified:   src/MakeTubs.cxx
	modified:   src/MakeUnion.cxx
	modified:   src/MulticopyProcessor.cxx
	modified:   src/PositionIndex.cxx
	modified:   src/StrictErrorHandler.cxx
	modified:   src/TransformProcessor.cxx
	modified:   src/TransformrefProcessor.cxx
	modified:   src/createdomdocument.cxx

fix application of some Eigen transforms, and correctly fill some CLHEP copies of cached members (to be checked if these are really needed in future)

Partially addresses ATEAM-677

Edward Moyse authored 4 years ago and Frank Winklmeier committed 4 years ago

Attempt to fix the CI failures.

The needed folders are not in COMP200.
Fixes crashes in SCT_ConditionsAlgorithms tests and q222.

See !37784.

Dropped the dependency on IGeoModelSvc::align(). Also moved all headers into
src directory

Enable `flake8` and make code compliant. Delete all obsolete job option
fragments in `share/`.

Enable thread-safety static checker.

Susumu Oda authored 4 years ago and Walter Lampl committed 4 years ago

Remove obsolete SiRegionSelectorTable, TRT_RegionSelectorTable, SCT_CablingToolInc, (I)SCT_FillCabling(FromTest/CoraCool)

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.