- Jan 06, 2021
-
-
-
Walter Lampl authored
Migrate LArCalib_PedestalAutoCorr_jobOptions.py and LArCalib_Delay_OFC_Cali_jobOptions.py to LArRawCalibDataReader + few more rel22 fixes. Incorporate code for LArCalib AFS area to LArExtendedSubDetGrouping.py
-
Walter Lampl authored
-
Walter Lampl authored
-
- Jan 05, 2021
-
-
Walter Lampl authored
-
Walter Lampl authored
-
- Dec 16, 2020
-
-
Rafal Bielski authored
-
Denis Damazio authored
-
- Dec 14, 2020
-
-
- Dec 11, 2020
-
-
- Dec 10, 2020
-
-
scott snyder authored
CompactBinnedArray maps bins in some coordinates to a vector of pointers to objects. It does not own this objects. BinnedMaterial uses CompactBinnedArray, with the object in question being a pair<> object. When a BinnedMaterial is constructed, it takes a vector of pointers to these pairs. It does not take ownership of this pairs, but just passes them to the CompactBinnedArray. The callers of BinnedMaterial also do not take ownership of these pairs. So they are presently leaked. Further, BinnedMaterial can't just delete them, because these pairs get shared between multiple BinnedMaterial instances. We restructure like this. BinnnedMaterial now gets a vector of pairs, which it saves as a member. The CompactBinnedArray is then constructed to that it points at the pairs in this vector. BinnedMaterial now effectively owns the pairs. These are now duplicated in each BinnedMaterial, but that should be ok. We also need to extend CompactBinnedArray so that we can give it a new vector of object pointers when it is cloned. cf ATLASRECTS-5831.
-
- Dec 08, 2020
-
-
scott snyder authored
Update the tower builder tool interfaces to pass the EventContext to the execute() methods. Should save some TLS looksups.
-
- Dec 07, 2020
-
-
Frank Winklmeier authored
Move detector-specific code to read the geometry database into standalone "[Det]GeoDB.py" modules. Use this code both in the old jobproperties as well as in the new-style `AutoConfigFlags` to avoid the copy&paste of the same code. Also fix the caching of `AutoConfigFlags.GetDetDescrInfo` to make sure the geometry DB is only queried once per geometry tag.
-
- Dec 05, 2020
-
-
scott snyder authored
Enable thread-safety checking. Fix identified issues. Also more constness fixes. Use conditions data in converters rather than relying on obsolete tools. Make pointers to block structure objects slot-specific.
-
- Dec 04, 2020
-
-
John Chapman authored
LArSimEventTPCnv_HITS - passes
-
John Chapman authored
LArTPCnv_15.6.7_test - passes (updated reference file) LArTPCnv_20.1.7.2_test - passes
-
scott snyder authored
Use the ElementLink variant of addUniqueCellNoKine to try to reduce lock contention.
-
- Dec 03, 2020
-
-
- Dec 02, 2020
-
-
scott snyder authored
Working towards getting this package to pass the thread-safety checker. Remove static members from LArRodEncoder; instead, pass in the helper objects to its ctor. Change it to use conditions data rather than then old legacy cabling service.
-
- Dec 01, 2020
-
-
John Chapman authored
The correct class name is `G4VFastSimulationModel` and is included via `FastSimulationBase.h`.
-
-
- Nov 30, 2020
-
-
Frank Winklmeier authored
Remove the following unused `TriggerFlags`: - doHLTpersistency - readLVL1Calo - readLVL1Muon - disableRandomPrescale - useOfflineSpacePoints - doNtuple - abortOnConfigurationError
-
Frank Winklmeier authored
`doLVL2` and `doEF` were used during Run-1 to configure the two-level HLT. This has not been supported since a long time and was replaced by a single `doHLT` flag. Adjust relevant python fragments.
-
- Nov 27, 2020
-
-
Goetz Gaycken authored
The CaloDescriptors must not be created before the alignment callback has been fired, because the descriptors cache the alignment transform at construction time. The creation of CaloDescriptors is e.g. triggered by the retrieval of the calorimeter detector description manager. To ensure that this happens after the alignment callback they are not retrieved anymore during the initialization of the calorimeter volume builders.
-
- Nov 25, 2020
-
-
scott snyder authored
Hid2RESrcID depends on the old, thread-unsafe LArCablingLegacyService. We can't get rid of it completely, because it's required by interfaces still used by TrigT2CaloCommon. Refactor so that it won't affect the thread-safety of the rest of this package. Split out the part of Hid2RESrcID required by FullEventAssembler into a separate base class RodRobIdMap. Split the remaining interfaces of Hid2RESrcID into thread-safe and thread-unsafe versions. Only the thread-safe functionality will be needed from this package; the thread-unsafe versions are needed only by TrigT2CaloCommon.
-
scott snyder authored
Missing find_package for ROOT.
-
-
Frank Winklmeier authored
Remove unused external dependencies, update link dependencies and enable flake8.
-
Frank Winklmeier authored
Remove unused XercesC dependency, fix link dependencies and enable flake8.
-
Pavol Strizenec authored
-
Pavol Strizenec authored
-
- Nov 24, 2020
-
-
Pavol Strizenec authored
-
Frank Winklmeier authored
Remove `atlas_depends_on_subdirs` and update link dependencies. The Eigen dependency can be removed once ATLASDD-40 is fixed.
-
Frank Winklmeier authored
- remove `atlas_depends_on_subdirs` - do not install component headers - update link dependencies - enable flake8
-
- Nov 23, 2020
-
-
scott snyder authored
Don't use exit(). Remove some const_cast / mutable. Make static data const.
-
- Nov 19, 2020
-
-
scott snyder authored
Make references to CaloCellCorrection instances const.
-
scott snyder authored
Make references to CaloCellCorrection instances const.
-
scott snyder authored
- Pass class instances by const reference, not by value.
-
scott snyder authored
Don't build an object into more than one library.
-
- Nov 18, 2020
-
-
scott snyder authored
- Prefer to pass large objects by const reference instead of by value. - Avoid post-increment of user iterators.
-