Skip to content
Snippets Groups Projects
  1. Jan 06, 2021
  2. Jan 05, 2021
  3. Dec 16, 2020
  4. Dec 14, 2020
  5. Dec 11, 2020
  6. Dec 10, 2020
    • scott snyder's avatar
      LArTrackingGeometry: Fix memory leaks · 5195048b
      scott snyder authored
      CompactBinnedArray maps bins in some coordinates to a vector of pointers
      to objects.  It does not own this objects.
      
      BinnedMaterial uses CompactBinnedArray, with the object in question
      being a pair<> object.
      
      When a BinnedMaterial is constructed, it takes a vector of pointers
      to these pairs.  It does not take ownership of this pairs, but just
      passes them to the CompactBinnedArray.
      
      The callers of BinnedMaterial also do not take ownership of these pairs.
      So they are presently leaked.
      
      Further, BinnedMaterial can't just delete them, because these pairs
      get shared between multiple BinnedMaterial instances.
      
      We restructure like this.
      
      BinnnedMaterial now gets a vector of pairs, which it saves as a member.
      The CompactBinnedArray is then constructed to that it points at the
      pairs in this vector.  BinnedMaterial now effectively owns the pairs.
      These are now duplicated in each BinnedMaterial, but that should be ok.
      We also need to extend CompactBinnedArray so that we can give it
      a new vector of object pointers when it is cloned.
      
      cf ATLASRECTS-5831.
      5195048b
  7. Dec 08, 2020
  8. Dec 07, 2020
    • Frank Winklmeier's avatar
      Refactor code to read GeoDB · e40ce6ea
      Frank Winklmeier authored
      Move detector-specific code to read the geometry database into
      standalone "[Det]GeoDB.py" modules. Use this code both in the old
      jobproperties as well as in the new-style `AutoConfigFlags` to avoid the
      copy&paste of the same code.
      
      Also fix the caching of `AutoConfigFlags.GetDetDescrInfo` to make sure the
      geometry DB is only queried once per geometry tag.
      e40ce6ea
  9. Dec 05, 2020
    • scott snyder's avatar
      LArByteStream: Enable thread-safety checking. · 717dbbcd
      scott snyder authored
      Enable thread-safety checking.
      Fix identified issues.
      Also more constness fixes.
      
      Use conditions data in converters rather than relying on obsolete tools.
      Make pointers to block structure objects slot-specific.
      717dbbcd
  10. Dec 04, 2020
  11. Dec 03, 2020
  12. Dec 02, 2020
    • scott snyder's avatar
      LArByteStream: thread-safety fixes · 3474d897
      scott snyder authored
      Working towards getting this package to pass the thread-safety checker.
      
      Remove static members from LArRodEncoder; instead, pass in the helper objects
      to its ctor.  Change it to use conditions data rather than then old
      legacy cabling service.
      3474d897
  13. Dec 01, 2020
  14. Nov 30, 2020
  15. Nov 27, 2020
    • Goetz Gaycken's avatar
      Avoid an early creation of CaloDescriptors. · 0f27b07b
      Goetz Gaycken authored
      The CaloDescriptors must not be created before the alignment callback has been
      fired, because the descriptors cache the alignment transform at construction
      time.
      
      The creation of CaloDescriptors is e.g. triggered by the retrieval of the
      calorimeter detector description manager. To ensure that this happens after the
      alignment callback they are not retrieved anymore during the initialization of
      the calorimeter volume builders.
      0f27b07b
  16. Nov 25, 2020
  17. Nov 24, 2020
  18. Nov 23, 2020
  19. Nov 19, 2020
  20. Nov 18, 2020
Loading