Closes ATEAM-677

Vakhtang Tsulaia authored 4 years ago and Tadej Novak committed 4 years ago

The names of decorations have been made consistent with the names of already existing
dynamic aux variables, in order to avoid having two dynamic variables for the same
pileup value (either actual or average)

Added sequence argument to the LumiBlockMuWriterDefault() function. If the argument
is set, then this sequence is used for LumiBlockMuWriter. Otherwise the appropriate
sequence is chosen by the LumiBlockMuWriterDefault() function itself.

Addresses ATR-22141

Frank Winklmeier authored 4 years ago and Walter Lampl committed 4 years ago

Add missing TestTools dependency for test executables.

Remove reference to undefined (and unneeded) CORAL_INCLUDE_DIRS.

Eric Torrence authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Several updates of iLumiCalc and associated scripts and html files
have been updated for the atlas-lumicalc website without ever being
committed back to the git master.  This patch brings the git master
back into sync with the code on the website, and provides bugfixes
for iLumiCalc that had been deployed on the website.

Don't declare dependencies on conditions objects that won't actually
be read.

Eric Torrence authored 4 years ago and Edward Moyse committed 4 years ago

Several updates of iLumiCalc and associated scripts and html files
have been updated for the atlas-lumicalc website without ever being
committed back to the git master.  This patch brings the git master
back into sync with the code on the website, and provides bugfixes
for iLumiCalc that had been deployed on the website.

 - Pass large objects by reference, not by value.
 - Prefer preincrement to postincrement for user iterators.
 - Prohibit copy for a class that manages memory.
 - Prefer to initialize members in an initialization list.
 

Use preincrement instead of postincrement.

Remove reference to nonexistent source file.

Library dependency fixes.

Missing override keywords.

  - LumiBlockMuWriter allows the input conditions handle key to be empty.
    In that case, it will write the decorations as 0.
    LumiBlockMuWriter is enabled for cosmic runs as well,
    with this configuration.

  - If the decorations already exist, they won't be overwritten.

  - If both online and mc are enabled, mc takes precedence.

See ATR-21360.

Fixed wrong import

This is a followup on !31668 (merged), which introduced the access to
pileup information from EventInfo via ReadDecorHandle-s

Also enabled LumiBlockMuWriter algorithm inside unHLT_standalone_run2.py

Also make sure LumiBlockMuWriter gets configured in tests that contain Mu DecorHandle
clients

General code cleanup:
   * Dropped several redundant properties and private data members
   * Dropped several redundant virtual functions
   * Switched to ATH_MSG macros
   * Some code readability improvements
   * Removed atlas_depends_on_subdirs from CMakeLists.txt
   * Client python scripts cleaned up from references to dropped properties of LumiBlockMetaDataTool

The only derived LumiBlockMetaDataTool provided dummy implementations for
the methods of the ILumiBlockMetaDataTool interface.

The ILumiBlockMetaDataTool inteface was dropped. The derived class and two clients
of this interface were cleaned up from the dependency on it.

Introduced new LumiBlockMuWriter algorithm, which fills pileup information
on xAOD::EventInfo using  WriteDecorHandle-s.

Enabled LumiBlockMuWriter algorithm in RecExCommon_topOptions.py for RAWtoESD
configurations over ByteStream input, and also unconditionally in
skeleton.RDOtoRDOtrigger.py and in runHLT_standalone.py

Ported one client - JetCalibrationTool - to accesing pileup
values in xAOD::EventInfo using ReadDecorHandle

Fixed ref_RDOtoRDOTrig_mt1_build.ref with updated trigger counts

By switching this algorithm from condition callback to Read Condition Handle we fixed
crashes in multithreaded reco jobs which run over multiple runs/lumi-blocks (ATLASRECTS-5389)

At the same time did some cleanup and refactoring of the code