Don't use fabs() with an integer argument.

Add back imports of units as they are used when specialConfiguration strings are evaluated - fixes ATLASSIM-4663

Replace usage of `dict.has_key(KEY)` with `KEY in dict`.

Replace usage of `dict.has_key(KEY)` with `KEY in dict`.

Fix or remove `atlas_install_*` statements that do not reference any
files.

Add missing installed libraries for interfaces and adapt other packages to use
interface libraries.

Update for python 3 compatibility.
Enable flake8 checking and fix warnings.

Ewelina Maria Lobodzinska authored 5 years ago and Frank Winklmeier committed 5 years ago

correct the package_filters to the 21.6 standard, add newest changes to the Herwig7_i interface and EvgenJobTransform and EvgenProdTools

 - print function

clang warnings:
 - Do not use std::move in a return statement.
 - Unused private data members.

clang warning: use std::abs not fabs for an integer argument.

clang warnings: unused private data members.

John Kenneth Anders authored 5 years ago and Atlas Nightlybuild committed 5 years ago

Monopole: Handle fractionally charged particles in 21.0

See merge request atlas/athena!26398

(cherry picked from commit 3d97df688faea867290146afa366f3d974f87ea8)

5b7016a4 Added code to handle fractionally charged particles
d12c4ec9 Remove redundant comment/update copyright statement

Unused parameters should simply not be named.

John Kenneth Anders authored 5 years ago and Miha Muskinja committed 5 years ago

Extra SM mesons

See merge request atlas/athena!24567

(cherry picked from commit be0fa5a8)

2dd0ce35 Implementation of basic vector D mesons

From version 10.6, Geant4 no longer exports G4MULTITHREADED in the
compiler flags as "-DG4MULTITHREADED". This symbol must be the same
between a build of Geant4 and any client application, so is instead
exported into configuration header included in the commonn G4Types.hh
header.

Update components of Athena that rely on this symbol so that they
explicitly #include G4Types.hh before using it.

InnerDetector has a private dependency on Geant4 headers added so
that it picks up the needed header path.

Marilena Bandieramonte authored 5 years ago and Walter Lampl committed 5 years ago

Fix thread-unsafety in Monopole code, G4mplEquationSetup class - Monopole MT  validation [ATLASSIM-4182]

G4mplEquationSetup class was implemented as a singleton, so it was not thread-safe. This affected MT simulation - with more than 1 thread:
the simulation was aborted for illegal values of energy, momentum and/or time.
Added the #ifdef G4MULTITHREADED directive to handle the multithreaded case. One instance of the class will be created per each thread
and stored in a tbb::concurrent_unordered_map that is hashed with the threadID number.

John Kenneth Anders authored 5 years ago and Atlas Nightlybuild committed 5 years ago

Fixes to RHadron simulation

See merge request atlas/athena!23714

(cherry picked from commit 7b0b7d9d3b14a85a553d171add99de1fa5d48f51)

adf48c06 Fixes to RHadron simulation

This merge request fixes two sets of problems.

First, there were problems in the logic that assigned hadronic
interactions to R-hadrons. The problem was essentially that one quark in
the light quark system was ignored when calculating the R-hadron
properties. This is (surprisingly) a quite good approximation as long as
you aren't making extremely heavy R-hadrons, and as long as you don't
have stop or sbottom R-mesons, where there is only one light quark in
the R-hadron. That's fixed, the list of R-hadron interactions has
changed somewhat, and the results change a little bit.

Second, we needed a few minor adjustments to get stop and sbottom
R-hadron simulation working. That should all be done. Validation plots
have been made and everything.

This MR gets master back in sync with 21.0 following !23144