- Jan 05, 2021
-
-
Stefano Rosati authored
-
-
- Jan 04, 2021
-
-
- Dec 22, 2020
-
-
scott snyder authored
Don't pass an uninitialized vector; pass a zeroed vector instead.
-
-
- Dec 21, 2020
-
-
scott snyder authored
class/struct mismatch. unused alias.
-
scott snyder authored
Needed to fix null pointer dereference warning in TRT_TrajectoryElement_xk, where we have ``` Tp.setParametersWithCovariance(0,P,V); ```
-
- Dec 18, 2020
-
-
scott snyder authored
In extrapolateStepwiseImpl, we need to delete the parameters in cache.m_parametersOnDetElements if we don't return them.
-
Christos Anastopoulos authored
Distance solution, move inline to .icc and use default. Also fix SCT_Digitization to used std::log, std::sqrt
-
Frank Winklmeier authored
This reverts merge request !39259
-
-
-
- Dec 17, 2020
-
-
scott snyder authored
No point in passing the pointer by (non-const!) ref --- it is never modified --- and this prevents calling with an rvalue.
-
Thomas Strebler authored
-
scott snyder authored
Make sure Eigen objects are initialized. Fixes uninitialized variable warnings from gcc.
-
- Dec 16, 2020
-
-
-
Edward Moyse authored
I think this fixes a crash I saw, presumably because inputTSOS_ID->end()-1 was invalid because inputTSOS_ID was empty.
-
- Dec 15, 2020
-
-
scott snyder authored
Misleading indentation.
-
Andrii Verbytskyi authored
-
-
- Dec 14, 2020
-
-
scott snyder authored
Missing braces in if statement.
-
-
- Dec 12, 2020
-
-
Christos Anastopoulos authored
-
-
Christos Anastopoulos authored
STEPPropagator, the magnetic field returns double. So prb no reason to convert to float and the back implicitly to double
-
- Dec 11, 2020
-
-
Christos Anastopoulos authored
-
-
Christos Anastopoulos authored
GSF, move methods that do not need to be class member (i.e not use anything from this) to be in an anonymous namespace
-
- Dec 10, 2020
-
-
Christos Anastopoulos authored
-
scott snyder authored
CompactBinnedArray maps bins in some coordinates to a vector of pointers to objects. It does not own this objects. BinnedMaterial uses CompactBinnedArray, with the object in question being a pair<> object. When a BinnedMaterial is constructed, it takes a vector of pointers to these pairs. It does not take ownership of this pairs, but just passes them to the CompactBinnedArray. The callers of BinnedMaterial also do not take ownership of these pairs. So they are presently leaked. Further, BinnedMaterial can't just delete them, because these pairs get shared between multiple BinnedMaterial instances. We restructure like this. BinnnedMaterial now gets a vector of pairs, which it saves as a member. The CompactBinnedArray is then constructed to that it points at the pairs in this vector. BinnedMaterial now effectively owns the pairs. These are now duplicated in each BinnedMaterial, but that should be ok. We also need to extend CompactBinnedArray so that we can give it a new vector of object pointers when it is cloned. cf ATLASRECTS-5831.
-
scott snyder authored
CompactBinnedArray maps bins in some coordinates to a vector of pointers to objects. It does not own this objects. BinnedMaterial uses CompactBinnedArray, with the object in question being a pair<> object. When a BinnedMaterial is constructed, it takes a vector of pointers to these pairs. It does not take ownership of this pairs, but just passes them to the CompactBinnedArray. The callers of BinnedMaterial also do not take ownership of these pairs. So they are presently leaked. Further, BinnedMaterial can't just delete them, because these pairs get shared between multiple BinnedMaterial instances. We restructure like this. BinnnedMaterial now gets a vector of pairs, which it saves as a member. The CompactBinnedArray is then constructed to that it points at the pairs in this vector. BinnedMaterial now effectively owns the pairs. These are now duplicated in each BinnedMaterial, but that should be ok. We also need to extend CompactBinnedArray so that we can give it a new vector of object pointers when it is cloned. cf ATLASRECTS-5831.
-
- Dec 09, 2020
-
-
-
Walter Lampl authored
-
Walter Lampl authored
-
- Dec 08, 2020
-
-
scott snyder authored
Missing override keywords.
-
scott snyder authored
Unused private data member.
-
scott snyder authored
Missing override keyword.
-
Nicolas Köhler authored
-
Frank Winklmeier authored
-
scott snyder authored
Missing override keywords.
-