Update test reference file for changes in HepMcParticleLink implementation.

This commit updates the TP converters in the `InDetSimEventTPCnv` package
to work with the new transient version of the `HepMcParticleLink` class.

All existing `InDetSimEventTPCnv` unit tests are updated to correctly set
the eventIndex property property of `HepMcParticleLinks` and check that
the event collection char member variable is set properly.

- add `override`
- remove unused retrieves of `ChronoStatSvc`

InDetCondTools doesn't build a library, so don't list it as a link dependency.

Also dropped the dependency on the old EventInfo from three other InDet packages

    
Change BCM_RawDataProvider to use WriteHandle.

By creating a dummy `HepMcParticleLink` ahead of creating the `Athena::LeakCheck` we can
avoid leak warnings from the static variable created by the class. The same approach is
used to mask a similar feature in the DVL Info. This all means that we can add back the
leak checking to these unit tests. In the longer term we will try to remove the static
variables from the `HepMcParticleLink` implementation - see ATLASSIM-3605.

By creating a dummy `HepMcParticleLink` ahead of creating the `Athena::LeakCheck` we can
avoid leak warnings from the static variable created by the class. The same approach is
used to mask a similar feature in the DVL Info. This all means that we can add back the
leak checking to these unit tests. In the longer term we will try to remove the static
variables from the `HepMcParticleLink` implementation - see ATLASSIM-3605.

This commit adds code to write rather than just read the persistent formats which
use `HepMcParticleLink_p2` to the relevant TP converters. These are the remaining
changes from `InDetEventAthenaPool-00-10-18`. These changes are part of the
`HepMcParticleLink` migration. See ATLASSIM-2430.

NB There are no unit tests for any of the `InDetSimData` TP Converters.

This commit updates the TP Converters which use `HepMcParticleLink_p1` to
properly initialize the new transient `HepMcParticleLink` class. It also
adds code to write the `SiHitCollection_p3` and `TRT_HitCollection_p4`
persistent formats (which use `HepMcParticleLink_p2`) to `SiHitCollectionCnv_p3`
and `TRT_HitCollectionCnv_p4` respectively.

HMPL-backward-compatibility fix for SiHitCollectionCnv_p2 from @arnaez.
(cherry picked from commit d3b8b24edb17ddb96f26a8feed92278d76fca9b9)

All existing `InDetSimEventTPCnv` unit tests are updated to use valid
`HepMcParticleLinks` and new unit tests for `SiHitCollectionCnv_p3` and
`TRT_HitCollectionCnv_p4` are added.

Compilation warning: superfluous const qualifier.

Files with identical content (same SHA1) but different file permissions
cause confusing differences shown in GitLab. The file permissions of
61 files were set to 644 (ATLINFR-2011).

Do not use `AthenaServices.SetFatalHandler` but instead set the
equivalent property on the CoreDumpSvc. Switch the remaining job options and
delete any comments referencing the old class.

A nice side effect is that the initial bootstrap of `athena.py` is now 3
seconds faster due to the removal of the `cppyy` import (of course this
time is spent later once the import happens at another place).


Former-commit-id: 021e1688626ce68e5faa67683820f68c789f5844

Susumu Oda authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Former-commit-id: 700afcce