Given the standalone library is based on Eigen instead of CLHEP, all GeoModel clients
in Athena code were also migrated to the Eigen-based interface of GeoModel. This affected
a large number of packages. Most significant changes have been introduced to subsystem
GeoModel packages.

The in-house GeoModelKernel code has been removed from the repository.

Almost all header files in PixelGeoModel have been moved to the src directory.
The next step should be turning this package into a component-only library.
Similar code reorganization can be applied to SCT_GeoModel too.

Subsystem readout geometry interfaces remain mostly unchanged, except for a minor
change in the InDet readout geometry interface (which was unavoidable).

Several non-GeoModel packages affected by this migration mostly required addition
of missing CLHEP includes.


Former-commit-id: 9cffebb1

In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment.  gcc9 now warns
about this by default.
Adjust to avoid the warning.


Former-commit-id: 4de4f4282b622b50fc810b87b87bcb8c3040056a

Former-commit-id: ceb7f12a

Update references to headers in CLIDSvc moved to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: 1396df09122439b0eecf2e0b36af6b34e85101ad

Defer imports that may load shared libraries until after job configuration
is complete.  Otherwise, we may get mysterious failures of the plugin loader.



Former-commit-id: ad54e1619388e05b746d4929c34fe03fab30d857

Defer imports that may load shared libraries until after job configuration
is complete.  Otherwise, we may get mysterious failures of the plugin loader.



Former-commit-id: 3dc4d8ca

Update references to headers in CLIDSvc moved to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: 04323fc4

Former-commit-id: 447b8d6c

(Binaries apparently include boost with -I rather than -isystem.)
Fixed in boost 1.68 (see https://github.com/boostorg/mpl/issues/31)



Former-commit-id: 230efd362c64ce818cfc87c8729044f1016acdf8

gcc8 warnings: Catching polymorphic exceptions by value.



Former-commit-id: 076af557749e5ef737259dc004131d40f5a16237

gcc8 warning: Catching polymorphic exception by value.



Former-commit-id: a11c75d6

Susumu Oda authored 6 years ago and Adam Edward Barton committed 6 years ago

Former-commit-id: af5d8ada

algorithm is a header-only library so there is no need to request it as
a component.


Former-commit-id: 69237d7296180dfaa86e60ca5eac462ce6c64e8a

Former-commit-id: 05e24830feea4cc658c527fe60fcfaf104a4110f

This reverts commit 6d8c8624 [formerly 8650a859].


Former-commit-id: bac9f4d6

Marcin Nowak authored 6 years ago and Adam Edward Barton committed 6 years ago

Former-commit-id: 0a971896

Former-commit-id: 8650a859

The Gaudi PluginSvc has been refactored and modernizes.
See gaudi/Gaudi!709

As well as some changes to macros that directly call on
certain features of the PluginSvc itself, other code that
has been impacted is as follows:

 - destructors of Converters must be public
 - template arguments of ServiceHandles and ToolHandles cannot always be forward defined and the associated header files may need to be explicitly included


Former-commit-id: 83042516

Former-commit-id: 79c31d23

Remove references to obsolete package DataModel.
Also clean up references to files in CLIDSvc and SGTools that were
moved to other packages.



Former-commit-id: c1338c4c

Former-commit-id: 35b263acd77f3f0c5d3196fb96f9d088758f4af1

James Beacham authored 7 years ago and Chris Hays committed 6 years ago

Former-commit-id: 80d522b9

major changes:

 - removal of DECLARE_FACTORY_ENTRIES
 - DECLARE_CONVERTER_FACTORY -> DECLARE_CONVERTER
 - DECLARE_TOOL_FACTORY -> DECLARE_COMPONENT
 - DECLARE_SERVICE_FACTORY -> DECLARE_COMPONENT
 - DECLARE_ALGORITHM_FACTORY -> DECLARE_COMPONENT
 - constructor of Converters is public, not protected
 - remove #include "GaudiKernel/CnvFactory.h"
 - remove #include "GaudiKernel/ToolFactory.h"
 - remove #include "GaudiKernel/AlgFactory.h"
 - remove #include "GaudiKernel/AudFactory.h"
 - remove #include "DeclareFactoryEntries.h"


Former-commit-id: fd7a40f56dee72487463a5004d85f32619f250ff

Former-commit-id: ea6b08f7

Add missing reference file.


Former-commit-id: 36fd6e99

Updating unit tests for SimHit and SDO TP Converters

See merge request atlas/athena!9151


Former-commit-id: 3e015fa310e3e1f2a5a0eb1ede90c1690a316d39

Add initial unit tests for HepMcParticleLinkCnv_p1, McEventCollectionCnv_p4 and…

See merge request atlas/athena!8923


Former-commit-id: eca386183fdaa956ffaa53770ff84769deb7db21

Fortran warning: spurious comma in write statement.


Former-commit-id: 06addfab

Former-commit-id: da68b820

Remove duplicated Gaudi property UseRndmGenSvc.

Adjust for change in type of m_pythia in base class.


Former-commit-id: 00f6f105

Add useRndmGenSvc(), to make it available to derived classes.

Change m_pythia to a unique_ptr, so that the Pythia instance doesn't
need to be created during genconf.


Former-commit-id: d3ad28de

Fortran warning: variable type mismatch.



Former-commit-id: d47fa6b4

Fortran warnings: spurious commas in write statements.


Former-commit-id: 54b7040b

Private static data members should start with s_.
Identifiers should not start with underscores.



Former-commit-id: 0766548b

Private data members should start with m_.


Former-commit-id: f7403d9b

Fortran compilation warning: string parameter length mismatch.


Former-commit-id: 65f3db68c468f00f2973e288424a6e2b525ef006

Compilation warnings:
  Unused private class data members.
  Unused fortran statement label.
  Consistent common block alignment between fortran and C++.
  


Former-commit-id: 284ac350

A long-standing bug in DataVector has meant that it was possible to get
a non-const pointer back from a DataVector::const_iterator.
HepMCAnalysis is abusing this to get a non-const pointer to a HepMC::GenEvent
object in StoreGate.

With this non-const pointer, HepMCAnalysis calls MeVToGeV, changing all the numbers
in the object to non-standard units.  This needs to be changed.  Besides just
the constness issue, this will cause bugs if combined with anything else
that accesses GenEvent.  And all numbers in ATLAS software should use ATLAS
unit conventions.  If the units must be changed, you should make a copy of the
GenEvent object and change that.

But a non-const pointer is also required to pass to the Process() and ClearEvent()
methods of baseAnalysis.  However, from a spot check, it doesn't appear that these
actually do change the GenEvent.  If so, then these interfaces should really
be changed to take a const pointer.

For now, make this implicit conversion explicit with a const_cast.
This will be required in order to finally fix the underlying DataVector bug.




Former-commit-id: 66e186f8

Former-commit-id: 9b39c6d9

clang warning: unused private data member.


Former-commit-id: 72ec510b