- Prefer preincrement to postincrement for user iterators.

 - Prefer preincrement to postincrement for user iterators.
 - Pass large structures by const reference rather than by value.

Peter Van Gemmeren authored 5 years ago and Frank Winklmeier committed 5 years ago

WIP: Remove some thread unfriendly state from AthenaOutputStream, AthenaPoolCnvSvc, mainly for multi-stream writing.

Scott Snyder authored 5 years ago and Walter Lampl committed 5 years ago

Remove non-standard use of #define private.

Add unit tests for the converter classes in this package.
Fix a few bugs uncovered thereby.

cppcheck warning: Prefer initializing members in an initialization list.

Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Extend AthenaPoolConverter::PoolToDataObject to pass the SG key.
To allow cleaning up xAOD converters for MT thinning.

Adjust for headers moved from SGTools to AthenaKernel.

Remove unneeded #include of ILArHVCorrTool.h.

    
Remove MT-unsafe uses of CaloIdManager.
Further cleanups.

    
Remove MT-unsafe uses of CaloIdManager.

Remove MT-unsafe uses of CaloIdManager.

- Add `override` keyword

Given the standalone library is based on Eigen instead of CLHEP, all GeoModel clients
in Athena code were also migrated to the Eigen-based interface of GeoModel. This affected
a large number of packages. Most significant changes have been introduced to subsystem
GeoModel packages.

The in-house GeoModelKernel code has been removed from the repository.

Almost all header files in PixelGeoModel have been moved to the src directory.
The next step should be turning this package into a component-only library.
Similar code reorganization can be applied to SCT_GeoModel too.

Subsystem readout geometry interfaces remain mostly unchanged, except for a minor
change in the InDet readout geometry interface (which was unavoidable).

Several non-GeoModel packages affected by this migration mostly required addition
of missing CLHEP includes.


Former-commit-id: 9cffebb1

Charles Leggett authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Former-commit-id: 645176ec682015530466012fae2ca493b87f4910

This reverts commit 6d8c8624 [formerly 8650a8592f4c96ffb3ed6993279bf999d98bc120].


Former-commit-id: bac9f4d616d35d02eadc79edd1b24b05cb69ca73

Former-commit-id: 8650a859

Remove references to obsolete package DataModel.
Also remove references to CLIDSvc and SGTools.



Former-commit-id: df6e02e06d5357e99b5ad5b1956259392692f931

Headers in this package are not used from any other package.
Move those to src.


Former-commit-id: dcf4b341

CaloCellCorrection methods are const.

CaloCellCorrection::MakeCorrection is now const, with an EventContext argument.
Adjust uses of it.
Working to make more of the calorimeter reconstruction reentrant.

Former-commit-id: c4b71645

major changes:

 - removal of DECLARE_FACTORY_ENTRIES
 - DECLARE_CONVERTER_FACTORY -> DECLARE_CONVERTER
 - DECLARE_TOOL_FACTORY -> DECLARE_COMPONENT
 - DECLARE_SERVICE_FACTORY -> DECLARE_COMPONENT
 - DECLARE_ALGORITHM_FACTORY -> DECLARE_COMPONENT
 - constructor of Converters is public, not protected
 - remove #include "GaudiKernel/CnvFactory.h"
 - remove #include "GaudiKernel/ToolFactory.h"
 - remove #include "GaudiKernel/AlgFactory.h"
 - remove #include "GaudiKernel/AudFactory.h"
 - remove #include "DeclareFactoryEntries.h"


Former-commit-id: fd7a40f5

@srettie spotted some lines in the muon code which ended with
two semicolons. As there is no convincing answer, they were
changed to single semicolons - and not only in muon code,
but throughout the repository (except generator packages).


Former-commit-id: 317d8317b24122874d8916e62e68ff74a3b727f8

Former-commit-id: 9b39c6d9

gcc8 warnings: catching polymorphic exceptions via value.


Former-commit-id: f65782f0

gcc8 warnings: catching polymorphic exceptions via value.


Former-commit-id: 22a43330

Remove references to obsolete package DataModel.



Former-commit-id: 9ad680a5

This reverts commit cdf718bf [formerly 9d67f5b8].


Former-commit-id: 008b62d0

Use the proper return type instead of relying on StatusCode/bool
conversions.


Former-commit-id: 292c3c6b