Use the new const interfaces of IPRD_AssociationTool to avoid
calling non-const functions through a const ToolHandle.

Susumu Oda authored 5 years ago and Adam Edward Barton committed 5 years ago

Original TrackSummary is copied if TrackSummaryTool is not found and TrackSummary is available. if-else style is unified in a part of the code.

clang warning: unused local typedef.

clang warning: unused variable.

Don't link against component library CaloTrkMuIdTools.

Fix path to PATInterfaces.

Make most methods of MuonTPExtrapolationTool const.
Needed to fix non-const calls through const ToolHandles.

Test has been timing out in recent nightlies.

The actual hole search is performed by the ID helper tool. The only
purpose of the tool was to toogle the ID hole search on or off.
The latter is now handled by a boolean property as is the case
for muons.

Adjust for headers moved from SGTools to AthenaKernel.

Update to work with current master.

Tile RUN3 cabling has been introduced.
It is different from RUN2a cabling only by absence of E4' cells.
To make it explicit that mostly the same RUN2 cabling functionality
is used for RUN3 cabling also the corresponding interface has been
renamed from RUN2 to RUN2+ (run2plus).

Emmanuel Le Guirriec authored 5 years ago and Adam Edward Barton committed 5 years ago

Make tools private in
- InDetDetailedTrackSelectorTool.cxx
- TrackSummaryTool.cxx
- KalmanVertexOnJetAxisSmoother.cxx
- TrkVKalVrtFitter.cxx

Create Cfg methods for new config

Test has been timing out in recent nightlies.

Test has been timing out in nightlies.

Update for headers moved from SGTools to AthenaKernel.

Update for headers moved from SGTools to AthenaKernel.

Update for headers moved from SGTools to AthenaKernel.
Also remove reference to obsolete CxxUtils::make_unique.

Adam Edward Barton authored 5 years ago and Edward Moyse committed 5 years ago

ATLAS_CHECK_THREAD_SAFETY on InDetV0Finder InDetSVWithMuonTool InDetVKalVxInJetTool JpsiUpsilonTools

Address MR Feedback

Update for headers moved from SGTools to AthenaKernel.

Update for headers moved from SGTools to AthenaKernel.

Adjust for headers moved from SGTools to AthenaKernel.

Adjust for headers moved from SGTools to AthenaKernel.

In the past there was a (very fragile) feature in atlas_add_root_dictionary(...)
that allowed it to scan the include definitions in a LinkDef.h file, and construct
the rootcint command based on that.

This feature has now been removed, as it was one of the most fragile parts
of our code. Now all users of atlas_add_root_dictionary(...) must declare explicitly
in CMake which headers they want to generate dictionaries for.

Emmanuel Le Guirriec authored 5 years ago and Adam Edward Barton committed 5 years ago

Make tools private in
- InDetDetailedTrackSelectorTool.cxx
- TrackSummaryTool.cxx
- KalmanVertexOnJetAxisSmoother.cxx
- TrkVKalVrtFitter.cxx

Create Cfg methods for new config

post_check.sh wasn't properly returning a failure code if the diff failed.
Fixed.
Also add a couple more patterns to ignore.

fixing bug where the caloTrigScale was inverted from the desired GeV/L1CaloScale to the incorrect L1CaloScale/GeV

Fixes failure observed in q222, evidently due to another change that
removed the import from another file.