Vakhtang Tsulaia authored 5 years ago and Adam Edward Barton committed 5 years ago

Modified EMBHVElectrode::hvLineNo() such that its reco clients now need to pass to it a pointer
to a LArHVIdMapping condition object, which provides mapping from electrodes to HV lines.

Migrated two clients of EMBHVElectrode - LArHVCondAlg and LArHVPathologyDbCondAlg - to the
new interface.

The AthSimulaton project was protected from the addition of new dependency on LArRecConditions
package, which hosts the LArHVIdMapping class, by leveraging the SIMULATIONBASE preprocessor statement

Scott Snyder authored 5 years ago and Adam Edward Barton committed 5 years ago

TileInfoLoader was playing games with the memory management of the TileInfo
object, removing it from the detector store at the end of a run and
adding it again at the start of a run.  None of this is needed, so clean
this up.  Also, TileInfo need not derive from DataObject and should get the
clid assigned properly with CLASS_DEF.

Thread safety check has been added to TileCablingSvc
and TileCablingService and fixed several issues found by checker.

Flake test has been added for files in TileConditions/python
directory and some issues found by test have been fixed.

TileGeoG4SDCalc has been marked for checking tread safety
and const correctness found by checker has been fixed.

Tile ROD decoder has been cleaned up
from commented code and unused properties.
Additional properties have been added to set up
amplitude and time thresholds for parabolic amplitude correction.
Time thresholds have been set up to +/- 12.5ns by default (half bunch spacing).
All properties have been moved into hader file.

Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Migrate TileCellBuilderFromHit and TileCellNoiseFilter from CaloNoiseTool
to the conditions algorithm.
In passing, fixes issues with calling non-const methods via const ToolHandles.

Manipulation with properties of Tile tools directly via ToolSvc
has been removed because it doesn't work anyway
since most of these tools are private.

Fix test failures in master.

Don't fetch EventContext from thread-local storage if we already have
it as an argument.

Marilena Bandieramonte authored 5 years ago and Walter Lampl committed 5 years ago

EscapedEnergyRegistry class was implemented as a singleton, so it was not thread-safe.
This affected the HITs of LArCalibrationHitDeadMaterial when running in MT with the CaloCalibration on.
Added the #ifdef G4MULTITHREADED directive to handle
the multithreaded case. One instance of the class will be created
per each thread and stored in a tbb::concurrent_unordered_map that
is hashed with the threadID number.

with an eye to HLT implementation

Allow disabling of some dependencies

Filling in missing parts of TopoCluster config

Make public LArHV tools private

Config module for LArHVScaleCorr

Expanding topocluster config with HV scale config

Attempt to extend PF config in directions usable at HLT

Readd calocluster building

Fix topocluster flag names

Slimming down PFHLTConfig.TrackingGeoCfg

Ugly fix for tile conditions pending better one from Walter

Fix import bugs for LArHVScaleConfig on MC, without actually making it work fully

Permit switching off most PFO moments

Remove inexplicably duplicated code in CaloCalTopoClusterConfig and fix for running on MC

Add ID and muon geo needed to get this running

Changes to make this run on MC, and produce new/old PFOs

one space indent

Remove redundant property declaration

Correction to CaloNoiseTool usage

Updating copyright years

Switching from CaloNoiseTool to CaloNoiseCondAlg

Adapting to CA changes

Update PF usage of B-field, extrapolators, other conditions

Make sure CondInputLoader runs before LArCabling alg

Supply class name for PileUpNoiseLumi

Convenient function isRun3Cabling() has been added into TileCablingService
for checking if Tile RUN3 cabling is used.

TileROD_Decoder tool has been modified
to use TileL2Builder tool via ToolHandle
in order to propagate dependency correctly.

Reference files for unit tests
have been updated accordingly.

Tile RUN3 cabling has been introduced.
It is different from RUN2a cabling only by absence of E4' cells.
To make it explicit that mostly the same RUN2 cabling functionality
is used for RUN3 cabling also the corresponding interface has been
renamed from RUN2 to RUN2+ (run2plus).

Adjust for headers moved from SGTools to AthenaKernel.

Walter Lampl authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

migrate CaloLCWeightTool to CaloNoise CDO. Pass EventContext to ClusterCellWeightTools via interface

Peter Onyisi authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Add trigger selection functionality for DQ monitoring tools in new configuration framework (ATLASDQ-711)

John Kenneth Anders authored 5 years ago and Atlas Nightlybuild committed 5 years ago

minor fixes TileCalibBlobPython package

See merge request atlas/athena!22129

(cherry picked from commit 53f131e2acdb302d717e31c34215bfaaabca5db2)

5b97fc12 adding laser timeout bits to h2000
9980e4b8 adding QDC timeout and TDC timeout variables to h2000 ntuple
0230ad70 Copyright updated
b0bc3424 Merge branch 'tilecal-for-21.0' of https://gitlab.cern.ch:8443/solodkov/athena...
655ff58d extra protection against invalid response in getLastRunNumber()

TilePulseMuonReceiver has been migrated to use
private tool for building Tile raw channels.

JO has been adapted to use private tools
for Tile muon receiver.

Property of TilePulseMuonReceiver have been moved inside
header file which has been moved in src directory.

Tile raw data containers allow to clear their collections.
But implementation of this functionality violates const correctness.
And since it seems not to be used at all this functionality has been removed.

The `AlgErrorAuditor` is obsolete. Remove its usage and the relevant
reconstruction flag (`rec.abortOnErrorMessage`).

Fix test failures in master.

New TileJetMonitorAlgorithm algorithm has been added
to monitor Tile time with jets for run 3.
Functionality has just been copied from TileJetMonTool.

New TileJetMonitorAlgorithm python module has been added
to configure this algorithm in new JO style.

New TileMonitoringCfgHelper module has been added
with helper functions which may be usefull for configuring
future Tile monitoring algorithm also.

In C++11, implicit declarations of copy and assignment are deprecated if the
class has a user defined destructor or copy or assignment.  gcc9 now warns
about this by default.
Adjust to avoid the warning.

Some methods of Tile containers, which allow modifying
the contents of containers, violate the const correctness.

Tile convertors have been migrated to use mutable Tile containers.
Methods of Tile containers, which violate the const correctness
have been removed.

Enable thread-safety static checker.

split TileCoolMgr into a class-definition that is compatible with run-3 style configuration flags and a separte file for backward-compatiblity