xAODTrigMissingETAthenaPool_21.0.79_test - passes (reference file updated)

xAODTrigEgammaAthenaPool_21.0.79_test - passes (reference file updated)

xAODTrigCaloAthenaPool_20.0.0.3_test - passes
xAODTrigCaloAthenaPool_21.0.79_test - passes (reference file updated)

xAODParticleAthenaPool_21.0.79_test - passes (reference file updated)

xAODPFlowAthenaPool_21.0.79_test - passes (reference file updated)

xAODMissingETAthenaPool_20.1.7.2_test - passes
xAODMissingETAthenaPool_21.0.79_test - passes (reference file updated)

xAODJetAthenaPool_20.7.2.2_test - passes
xAODJetAthenaPool_21.0.79_test - passes (reference file updated)

xAODEgammaAthenaPool_20.1.7.2_test - passes
xAODEgammaAthenaPool_21.0.79_test - passes (reference file updated)

xAODCaloRingsAthenaPool_21.0.79_test - passes (reference file updated)

xAODCaloEventAthenaPool_20.1.7.2_test - passes
xAODCaloEventAthenaPool_21.0.79_test - passes (reference file updated)

xAODTauAthenaPool_20.1.7.2_test - passes
xAODTauAthenaPool_20.7.2.2_test - passes
xAODTauAthenaPool_21.0.79_test - passes (reference file updated)

xAODBTaggingAthenaPool_21.0.79_test - passes (reference file updated)

xAODTrackingAthenaPool_20.1.7.2_test - passes
xAODTrackingAthenaPool_20.7.2.2_test - passes
xAODTrackingAthenaPool_21.0.79_test - passes (refrence file updated)
xAODTrackingAthenaPool_master-20190911_test - passes (reference file updated)

xAODEventShapeAthenaPool_21.0.79_test - passes (reference file updated)

xAODEventInfoAthenaPool_20.0.0.3_test - passes

EventBookkeeperTPCnv_16.0.0_test - passes
EventBookkeeperTPCnv_18.0.0_test - passes

xAODTruthAthenaPool_21.0.79_test - passes (updated reference file)

EventTPCnv_15.0.0_test - passes
EventTPCnv_17.5.0_test - passes
EventTPCnv_18.0.0_test - passes
EventTPCnv_20.1.7.2_test - passes

Closes ATEAM-677

Mention ShallowCopyDecorDeps in the comments of the ShallowCopy functions.

Frank Berghaus authored 4 years ago and Frank Winklmeier committed 4 years ago

There should be no need to expose the header of the FileMetaDataTool to
other packages, it can be treated as a component and called through its
interface. Remove some unneeded headers. Enable checking for thread
safety.

This code is needed by AnalysisBase as well after all, so it can't
be in xAODBTaggingAthenaPool as it turns out.

Xiaozhong Huang authored 4 years ago and Adam Edward Barton committed 4 years ago

Add a tool, i.e. TauVertexedClusterDecorator, to decorate the vertex
correctd cluster to the tau candidate. To make the EDM simple, the
calculation of dR is moved to TauxAODHelpers.

Nils Krumnack authored 4 years ago and Nils Erik Krumnack committed 4 years ago

This has been a long time coming, but one of the reasons for having
AsgMessaging as a separate package from AsgTools is to allow
xAODRootAccess to depend on it and use the same status codes and
messaging as the rest of analysis base.  This should take part of the
former.

I had to add the RECOVERABLE code to the main status code, but since
that is also part of the Gaudi StatusCode that seems like a reasonable
change/extension.

Apart from that this is mostly a global search replace to move all
users from TReturnCode to StatusCode, but apart from fixing up a
couple of places related to the status code itself I did not try to
fix/improve any code in the process.

Note that this also revealed a number of tests that failed because
they used RETURN_CHECK() incorrectly.  This commit doesn't try to
address that.

 - Missing override keywords.

Add missing xAODRootAccess link dependency for athena build.

Michele Renda authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

In this commit we made public the member of EventStreamInfo_p1.h
to allow the extraction of the metadata values

Xiaozhong Huang authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

For Topo seed jets, the cluster links in the tau candidate point to the
clusters in a shallow copy container, which will not be available in AOD
of R22. To fix this, the cluster links point to the cluster in the
original container.

For PFlow seed jets, the cluster links in the tau candidate point to the
PFOs(neutral or charged). It is confusing. Now the cluster links point
to the corresponding cluter in the PFO object.

Previously, only clusters within 0.2 cone of tau candidate is stored. In
the tau reconstruction, we need all the clusters. Thus the cut of dR is now
removed.

The clusters could have energy <=0, which will be skimmed in AOD. The
link then becomes invalid. Since we do not want an invalid link, all
the clusters are requied to have positive energy.

Fix a couple locking probelems in EventSelectorByteStream that could
cause us to try to acquire the lock recursively, leading to a deadlock.

See ATEAM-665.