Merge branch 'cppcheck.LArRawEvent-20230929' into 'main'

LArRawEvent+TrigT1Interfaces: Fix cppcheck warnings.

See merge request atlas/athena!66168

LArCalorimeter/LArRawEvent/LArRawEvent/LArAccumulatedDigit.h

 /*
-  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -108,10 +108,10 @@ public:
                      const std::vector <uint64_t>& sampleSquare,
 		     const unsigned nTrigger);
 
-  void setAddSubStep(CaloGain::CaloGain gain_value, std::vector<uint64_t> sampleSum,
- 		     std::vector < uint64_t > sampleSquare, unsigned nTrigger);
-  void setAddSubStep(CaloGain::CaloGain gain_value, std::vector<int64_t> sampleSum,
- 		     std::vector < int64_t > sampleSquare, unsigned nTrigger, int32_t base);
+  void setAddSubStep(CaloGain::CaloGain gain_value, const std::vector<uint64_t>& sampleSum,
+ 		     const std::vector < uint64_t >& sampleSquare, unsigned nTrigger);
+  void setAddSubStep(CaloGain::CaloGain gain_value, const std::vector<int64_t>& sampleSum,
+ 		     const std::vector < int64_t >& sampleSquare, unsigned nTrigger, int32_t base);
 
 
   bool setAddSubStep(const LArAccumulatedDigit& ad) {

LArCalorimeter/LArRawEvent/src/LArAccumulatedDigit.cxx

@@ -146,8 +146,8 @@ bool LArAccumulatedDigit::setAddSubStep(const CaloGain::CaloGain gain_value,
 }
 
 
-void LArAccumulatedDigit::setAddSubStep(CaloGain::CaloGain gain_value, std::vector<uint64_t> sampleSum,
-					std::vector <uint64_t> sampleSquare, unsigned nTrigger)
+void LArAccumulatedDigit::setAddSubStep(CaloGain::CaloGain gain_value, const std::vector<uint64_t>& sampleSum,
+					const std::vector <uint64_t>& sampleSquare, unsigned nTrigger)
 {
   std::vector<uint64_t> tmpSum;
   std::vector<uint64_t> tmpSquare;
@@ -185,8 +185,8 @@ void LArAccumulatedDigit::setAddSubStep(CaloGain::CaloGain gain_value, std::vect
   tmpSquare.clear();
 }
 
-void LArAccumulatedDigit::setAddSubStep(CaloGain::CaloGain gain_value, std::vector<int64_t> sampleSum,
-					std::vector <int64_t> sampleSquare, unsigned nTrigger,
+void LArAccumulatedDigit::setAddSubStep(CaloGain::CaloGain gain_value, const std::vector<int64_t>& sampleSum,
+					const std::vector <int64_t>& sampleSquare, unsigned nTrigger,
 					int32_t base)
 {
   int64_t  tmpBase;

Trigger/TrigT1/TrigT1Interfaces/TrigT1Interfaces/CTPSLink.h

 /*
-  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
 */
 #ifndef TRIGT1INTERFACES_CTPSLINK_H
 #define TRIGT1INTERFACES_CTPSLINK_H
@@ -121,7 +121,7 @@ namespace LVL1CTP {
       unsigned int m_wordsPerCTPSLink;       //!< number of words per CTPSLink
 
       //! convert data contetn into string (used by dump and print)
-      const std::string convert(std::vector<uint32_t> data,
+      const std::string convert(const std::vector<uint32_t>& data,
                                 const bool longFormat = false) const;
 
 

Trigger/TrigT1/TrigT1Interfaces/src/CTPSLink.cxx

 /*
-  Copyright (C) 2002-2022 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2023 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "TrigT1Interfaces/CTPSLink.h"
@@ -212,7 +212,7 @@ namespace LVL1CTP {
     return s.str();
   }
 
-  const std::string CTPSLink::convert(std::vector<uint32_t> data, const bool longFormat) const
+  const std::string CTPSLink::convert(const std::vector<uint32_t>& data, const bool longFormat) const
   {
     std::ostringstream s;