Skip to content

[MISSING-REQUIREMENTS][#9]Send-emails-with-TLS

Caetan Tojeiro Carpente requested to merge dev_send_emails_with_tls into master

I don't have so much knowledge about emailing and protocols, but I think that now the email is sent with TLS since the first hop has TLS header

imagen_2020-12-10_104342

I also checked an email sent without the changes and this header was not present in the first hop.

I also changed the .env file to add both ways to develop:

  • Sending emails to the console
  • Sending emails to the email in the whitelist

It's not the best way to do it but I think is more simple to switch between context like this and not changing them manually. Also if new people join the project I think it will be easier for them to do it and not ask others for the envs for the second case, since in the repo there are only the envs for console emails.

In addition I added to the README a tip for problems with dependencies (since the last commit updated and add some and it was necessary to rebuild the notification-consumers container)

However, if you want to keep it as it is right now I can change it 😄

Edited by Carina Antunes

Merge request reports