Addressing comments from MR review

Trigger/TrigAlgorithms/TrigTauRec/python/TrigTauRecConfigMT.py

@@ -138,7 +138,6 @@ class TrigTauRecMerged_TauPreselection (TrigTauRecMergedMT) :
                 
             from TrigTimeMonitor.TrigTimeHistToolConfig import TrigTimeHistToolConfig
             time = TrigTimeHistToolConfig("Time")
-            #self.AthenaMonTools = [ time, validation, online ]
 
             import TrigTauRec.TrigTauAlgorithmsHolder as taualgs
             tools = []

Trigger/TrigHypothesis/TrigTauHypo/src/ITrigTrackPreSelHypoTool.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 #ifndef TRIGTAUHYPO_ITrigTrackPreSelHypoTool_H
 #define TRIGTAUHYPO_ITrigTrackPreSelHypoTool_H 1

Trigger/TrigHypothesis/TrigTauHypo/src/TrigTauTrackRoiUpdaterMT.cxx

@@ -58,10 +58,10 @@ StatusCode TrigTauTrackRoiUpdaterMT::execute(const EventContext& ctx) const
 
 
   ATH_MSG_DEBUG( "Running "<< name() <<" ... " );
-  //const EventContext& ctx = getContext();
 
   // Prepare Outputs
-  std::unique_ptr< TrigRoiDescriptorCollection > roICollection( new TrigRoiDescriptorCollection() );
+  auto roICollection = std::make_unique<TrigRoiDescriptorCollection>();
+  //std::unique_ptr< TrigRoiDescriptorCollection > roICollection( new TrigRoiDescriptorCollection() );
 
   // Retrieve Input TrackCollection
   SG::ReadHandle< TrackCollection > TrackCollectionHandle = SG::makeHandle( m_tracksKey,ctx );
@@ -69,7 +69,7 @@ StatusCode TrigTauTrackRoiUpdaterMT::execute(const EventContext& ctx) const
   const TrackCollection *foundTracks = TrackCollectionHandle.get();
   ATH_MSG_DEBUG( "Found " << foundTracks->size() << " fast Tracks found, updating the corresponding RoI ... " );
 
-  if(foundTracks != NULL) {
+  if(foundTracks) {
     ATH_MSG_DEBUG( "REGTEST: Size of vector CaloCluster container is " << foundTracks->size());
     if(foundTracks->size()==0) {
       ATH_MSG_DEBUG( "Cannot proceed, size of vector CaloCluster container is " << foundTracks->size());

Trigger/TrigHypothesis/TrigTauHypo/src/TrigTauTrackRoiUpdaterMT.h

 /*
-  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef TRIGTAUHYPO_TrigTauTrackRoiUpdaterMT_H
@@ -21,8 +21,7 @@ class TrigTauTrackRoiUpdaterMT : public AthReentrantAlgorithm {
   ~TrigTauTrackRoiUpdaterMT();
   
   virtual StatusCode initialize() override;
-  //StatusCode finalize();
-  StatusCode execute(const EventContext&) const;
+  virtual StatusCode execute(const EventContext&) const override;
 
  private:
 

Trigger/TrigHypothesis/TrigTauHypo/src/TrigTrackPreSelHypoAlgMT.cxx

@@ -25,7 +25,8 @@ StatusCode TrigTrackPreSelHypoAlgMT::initialize() {
   return StatusCode::SUCCESS;
 }
 
-StatusCode TrigTrackPreSelHypoAlgMT::finalize() {   
+
+StatusCode TrigTrackPreSelHypoAlgMT::finalize() {
   return StatusCode::SUCCESS;
 }
 

Trigger/TrigHypothesis/TrigTauHypo/src/TrigTrackPreSelHypoTool.h

@@ -41,10 +41,6 @@ class TrigTrackPreSelHypoTool : public extends<AthAlgTool, ITrigTrackPreSelHypoT
 
   HLT::Identifier m_decisionId;
 
-  //Gaudi::Property<bool>  m_decisionPerCluster{ this, "DecisionPerCluster", true, "Is multiplicity requirement refering to taus ( false ) or RoIs/clusters with taus ( false ), relevant only in when multiplicity > 1" };
-  //Gaudi::Property<bool>  m_respectPreviousDecision{ this, "RespectPreviousDecision", false, "If false, ( do not even check ), the decision made for the cluster" };
-  //Gaudi::Property<bool>  m_acceptAll{ this, "AcceptAll", false, "Ignore selection" };
-
   Gaudi::Property<float>  m_lowerPtCut{ this, "lowerPtCut", 20000.0, "" };
   Gaudi::Property<float>  m_lowerTrackPtCut{ this, "lowerTrackPtCut", 0.0, "" };
   Gaudi::Property<float>  m_clusterCone{ this, "clusterCone", 0.2, "" };

Trigger/TrigValidation/TrigUpgradeTest/python/tauDefs.py

+#
+#  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
+#
+
 from AthenaCommon.AppMgr import ServiceMgr as svcMgr
 from AthenaCommon.Constants import VERBOSE,DEBUG,INFO, ERROR
 from AthenaCommon.CFElements import parOR, seqAND, seqOR, stepSeq

Trigger/TrigValidation/TrigUpgradeTest/python/tauMenuDefs.py

 #
-#  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
+#  Copyright (C) 2002-2019 CERN for the benefit of the ATLAS collaboration
 #
 
 from AthenaCommon.Include import include
@@ -84,11 +84,6 @@ def tauCoreTrackSequence():
     ViewVerify.OutputLevel = DEBUG
     viewAlgs.append(ViewVerify)
 
-    #TrackParticlesName = ""
-    #for viewAlg in viewAlgs:
-    #   if viewAlg.name() == "InDetTrigTrackParticleCreatorAlg":
-    #     TrackParticlesName = viewAlg.TrackParticlesName
-
 
     from TrigTauHypo.TrigTauHypoConf import TrigTauTrackRoiUpdaterMT
     TrackRoiUpdater = TrigTauTrackRoiUpdaterMT("TrackRoiUpdater")