Add checks for IP and MAC address conflict, Follow-up from "Support for PyHAL-based write/read, adding function execution requests and support for VCU128 tcp/ip-based firmware"
We need to add checks for MAC and IP addresses conflicts. The code is in the Dominique's DTH_controller: https://gitlab.cern.ch/cms_daq_dth/dth_daq_controller/-/blob/master/DTH_control.py?ref_type=heads#L1037
The following discussion from !37 (merged) should be addressed:
-
In general if ARP reply doesn't come then the correct ERROR message is: "Destination host unreachable". This error is fatal, because it is a network problem.
Concerning the particular line 1206, this is a double check that the MAC address returned by the ARP logic (from the ARP rpely) is valid. If it is zero then we have a "runtime error" or more "firmware error", because that should not happen. Most likely it is a bug in the firmware.
The error message should be something like: "The MAC address of the destination is invalid!"
--
Something else: The code following the ARP logic is also missing a very important check for the MAC and IP addresses duplicates that needs to be put in place, better soon. Please check the latest DTH controller from Dominique.