Skip to content
Snippets Groups Projects
Commit 3d96565d authored by Philip Elson's avatar Philip Elson :snake:
Browse files

Merge branch 'no_raise' into 'master'

Revert exception raising until more confidence in registration system exists.

See merge request !19
parents b38c2254 444bd8e5
No related branches found
No related tags found
1 merge request!19Revert exception raising until more confidence in registration system exists.
Pipeline #1350914 passed
......@@ -344,7 +344,6 @@ class Manager(object):
)
except Exception as e:
self.log.error(e)
raise
if ret:
self._save_modules(modules)
return tuple(ret)
......
......@@ -69,22 +69,25 @@ def test_no_such_module(caplog, simple_resolver):
]
def test_module_missing_special_resolver_attr(simple_resolver):
def test_module_missing_special_resolver_attr(caplog, simple_resolver):
with tmp_mod('a_cmmnbuild_test_module'):
with pytest.raises(AttributeError) as err:
cbdm.Manager('a_cmmnbuild_test_module')
assert str(err.value) == (
"module a_cmmnbuild_test_module does not declare "
"__test_resolver_deps__, which is needed for SimpleResolver "
"(The test resolver which does nothing) ")
cbdm.Manager('a_cmmnbuild_test_module')
warning = (
"cmmnbuild_dep_manager", logging.ERROR,
'module a_cmmnbuild_test_module does not declare '
'__test_resolver_deps__, which is needed for SimpleResolver '
'(The test resolver which does nothing) ')
assert warning in caplog.record_tuples
def test_module_dependencies_no_version(simple_resolver):
def test_module_dependencies_no_version(caplog, simple_resolver):
with tmp_mod('a_cmmnbuild_test_module', dependencies=['j1', 'j2']):
with pytest.raises(AttributeError) as err:
cbdm.Manager('a_cmmnbuild_test_module')
assert str(err.value) == (
cbdm.Manager('a_cmmnbuild_test_module')
warning = (
"cmmnbuild_dep_manager", logging.ERROR,
"module 'a_cmmnbuild_test_module' has no attribute '__version__'")
assert warning in caplog.record_tuples
@contextmanager
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment