Skip to content
Snippets Groups Projects

provide import system access through context manager

Merged Michi Hostettler requested to merge jpype-imports-context-manager into master
All threads resolved!

As discussed this morning.

I did not add tests for this functionality as it requires a running JVM (which other tests don't). If you have a good idea how to monkey-patch jpype to mock the calls needed in a smart way, I'd of course appreciate any proposals for tests.

Merge request reports

Pipeline #1653679 passed

Pipeline passed for 0b92ed73 on jpype-imports-context-manager

Approval is optional

Merged by Michi HostettlerMichi Hostettler 5 years ago (Jun 10, 2020 11:40am UTC)

Merge details

  • Changes merged into master with c1866938.
  • Deleted the source branch.

Pipeline #1704538 passed

Pipeline passed for c1866938 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Michi Hostettler resolved all threads

    resolved all threads

  • added 1 commit

    • 0b92ed73 - review comments; remove >>> prompts from examples

    Compare with previous version

  • mentioned in commit c1866938

  • Please register or sign in to reply
    Loading