Skip to content
Snippets Groups Projects

Adding getLastTrimAtTimestamp function

Open Alexandre Lasheen requested to merge ps-rf-operation/forks/pjlsa:master into master

The getLastTrimAtTimestamp function is following the same methods as _getTrimsByCycle, except that it uses the ContextSettingsRequestBuilder at specific timestamp to get the trim at that stage in time rather than getting all trim headers.

Two possibilities for proper inclusion:

  • The feature could possibly be included in the _getTrimsByCycle and _getTrimsByBeamprocess functions directly adding timestamp as keyword argurment, in addition to start and end.
  • The following segment could be refactored and distributed in _getTrimsByCycle, _getTrimsByBeamprocess without changing their signatures (start and end as kwargs), then having different functions with dedicated input timestamp as kwarg.
    for pp in parameterList:
        ...
    • The effective timestamp of the trim is obtained from setting.getCreationDate() rather than th.getCreatedDate() as trim headers are not obtained.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading