Skip to content
Snippets Groups Projects

Integrate type annotations inline into PyJapc

Merged Philip Elson requested to merge pelson/pyjapc:maint/recommended_jpype_usage into master

A substantial change to remove the _japc.pyi and replace it with inline type annotations (plus a separate typing pyi file for common definitions).

There were one or two cases where the type annotations weren't fully correct in _japc.pyi. I have fixed the ones that triggered errors with mypy. I do not intend to correct the inherited (and incorrect) callback annotations in this MR.

Merge request reports

Pipeline #3909258 passed

Pipeline passed for ba5a24d5 on pelson:maint/recommended_jpype_usage

Approval is optional

Merged by Ivan SinkarenkoIvan Sinkarenko 2 years ago (May 2, 2022 1:10pm UTC)

Merge details

  • Changes merged into master with bfa63032.
  • Deleted the source branch.

Pipeline #3975787 passed

Pipeline passed for bfa63032 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson
  • Philip Elson added 1 commit

    added 1 commit

    • bf6557ea - Review of changes, and get the tests passing

    Compare with previous version

  • Philip Elson added 2 commits

    added 2 commits

    • 4639958e - Review of changes, and get the tests passing
    • 1ca8c848 - Fix failing test when testing against master of JPype

    Compare with previous version

  • Philip Elson added 1 commit

    added 1 commit

    • 1f4c13d5 - Fix failing test when testing against master of JPype

    Compare with previous version

  • Philip Elson added 1 commit

    added 1 commit

    • 061dc24f - Fix failing test when testing against master of JPype

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading