DISCUSSION: Make TOT Latch reset optional

For waferprobing we need to comment out the ptot latch reset in order to guarantee stable communication. In addition to that The ITkPixV1.1 is expected to no longer need this feature. Therefore I would like to make it programmable in testbench.Any other thoughts on that?

added Discussion label

mhh. it'a specific feature for one chip that will not be used for a long time.. maybe the testbench is not the best place for such a parameter.. if it's only for waferporbing, indroducing a parameter to itkpixv1.__init__() would be enough, since this is only called at one place in a wp specific script?

It will be used just as much as the Ptot parameter, which is in testbench.yaml

but PToT will be included as an optinal feature in all RD53B chips, won't it?

So will the Latch reset. As soon as itkpixv1.1 arrive I guess we do not want to write a new class, correct?

but the latch reset will not be necessary for any chip other than ItkPixV1. Why not have a dedicated class? It's a different chip?

At some point we could think about introducing another level of base class for all RD53B based chips..

As a compromise we could add it here: https://gitlab.cern.ch/silab/bdaq53/-/blob/development/bdaq53/chips/ITkPixV1_default.cfg.yaml

I would add it in the testbench.yaml as a chip_parameter, like use_ptot. Why not?

If you feel it's necessary I'm just worried a bit that the testbench is getting overloaded..

If we use .get its all optional :) https://gitlab.cern.ch/silab/bdaq53/-/blob/itkpixv1_devel/bdaq53/chips/ITkPixV1.py#L585 If chip config is ok for everyone I'll open the MR.

@mstandke can we maybe merge first !388 (merged)? Since this is some small cleanup to the ITkPixV1 class and you are also touching it.

Sure, whats's missing in !388 (merged) ?

Its done. Was only a small cleanup. But better to merge it now. More can follow later.

I think arbitrary chip settings could be put into testbench.yaml. It can have arbitrary key/value pairs and will never crash, so there is also no risk if unused settings when switching chip type.

Did you open already a MR?

I like the idea, however I dont understand why only parts of _reset_tot() are skipped if reset_tot_latches is True. In addition, you should make a rebase since !388 (merged) changed the ITkPixV1 class.