Fix tune tdac
This MR fixes and enhances:
Regression:
- TDAC data type change leading to mainly useless mask
Bugs:
- Fit-less S-Curve analysis did not work on inverted S-Curves
Enhancements:
- TDAC injection tuning algorithm was insufficient for noisy pixels. This should be enhanced now by fit range selection allowing to tune to much lower thresholds with injection. These plots show for example the selected data for S-Curve analysis over the measured data from the differential flavour: .
@mstandke veryfied for one double column of the differential flavour that tuning with injection does work:
To be also checked with linear flavour @mdaas
- Proper tune TDAC scan structure: the TDAC specific analysis is actually happening in the TDAC scan analysis step, much less verbose...
Testing coverage:
- Unit test for lin. TDAC tuning / diff. TDAC tuning analysis step to keep this regression from happening again. Also created TDAC mask is tested.
Note:
- There is still room for improvement for the algorithm.
- For weird data runtime errors might occur:
- first bug spotted and addressed: if selected data has < 3 point s-curve fit is not possible
Edited by David-Leon Pohl