Scan base cleanup
Loading
This MR cleans the scan base. Addresses #334 (closed) #336 (closed) #347.
Changes in addition to the issues:
per module
scan featureinit
stepmodule_name/chip_name
. Different serial number does not have to be defined, to ease quick testing of modules.testbench
if power cycling is wanted. This is not a parameter of a scan any more.testbench
if record chip status is wanted. This is not a parameter of a scan any more.scan_config_override_per_scan
--> scan_config_per_chip
chip_configuration
empty means that chip config of latest scan is loaded. auto
is not needed any more. Renaming to chip_config_file
, since the chip configuration is more than the file.chip_conf_directory
in testbench
any more. The chip path defines it already and one can change the config files already.bdaq
config key in scan_configuration
to bench
, since it updates the bench configtestbench.yaml
to use_good_pixels_diff
scan.scan
will be re-renamed to old method name start
configuration_in
) and a final configuration after analysis (configuration_out
)Regressions:
send_address
for all chips are differentOpen questions:
VCAL_HIGH
setting is taken from previous scan --> should be ok, since all scans that use injection are in charge to set the registers as needed and should not rely on std. cfgs.chip
key for chip related scan settings? --> it is not the case that scan_configuration sets chip registers directlydisable_pixel
to use_pixel
, since the logic is inverted? --> YesStatus:
Vthin_x
) are written to configuration_out