WIP: Module flexible chip id numbering (!504) · Merge requests · silab / bdaq53 · GitLab

Snippets Groups Projects

Merged Konstantin Mauer requested to merge module_flexible_chip_id_numbering into development 2 years ago

With this change one can modify the chip_id map in the module definition on a chip basis. Thus the same module type can be used even though chips have different chip ids for different chip types. (e.g. [13, 14, 15, 12] in case of ITkPixV1)

Fixes #504 (closed)

Edited 2 years ago by Yannick Manuel Dieter

Activity

Konstantin Mauer added Bug label 2 years ago

added Bug label
Konstantin Mauer assigned to @kmauer 2 years ago

assigned to @kmauer
Konstantin Mauer added 1 commit 2 years ago
added 1 commit

26519b0f - FIX: codestyle

Compare with previous version
Konstantin Mauer mentioned in issue #504 (closed) 2 years ago

mentioned in issue #504 (closed)
Konstantin Mauer added 1 commit 2 years ago
added 1 commit

ce89d36b - FIX: Typo

Compare with previous version
Thomas Christian Senger @tsenger 2 years ago

Contributor

I will test it later for a RD53A quad module
Konstantin Mauer added 1 commit 2 years ago
added 1 commit

5d42303e - ENH: better chip_id map in module_types

Compare with previous version
Konstantin Mauer added 1 commit 2 years ago
added 1 commit

aa7c847c - FIX: wrong shape of chip id map

Compare with previous version
Thomas Christian Senger @tsenger 2 years ago

Contributor

The chip IDs for the common RD53A quad are still wrong, should be 1-4 and not 0-3

Edited 2 years ago by Thomas Christian Senger
Y

Yannick Manuel Dieter @ydieter 2 years ago

Owner

Can you fix that @kmauer, please?
Konstantin Mauer added 1 commit 2 years ago
added 1 commit

1d76a623 - ENH: simplification of extend_maps

Compare with previous version
Konstantin Mauer added 54 commits 2 years ago
added 54 commits

1d76a623...3379a842 - 47 commits from branch development

5b5f0b6c - ENH: Allows to use chip ids 1 to 4

e08793dd - ENH: set arbitrary chip ids per chip

0879690d - FIX: codestyle

70b1af47 - FIX: Typo

c595d8ca - ENH: better chip_id map in module_types

8b509c8d - FIX: wrong shape of chip id map

dea8096b - ENH: simplification of extend_maps

Compare with previous version
Toggle commit list
Yannick Manuel Dieter added 9 commits 2 years ago
added 9 commits

dea8096b...5e931229 - 2 commits from branch development

ab419abd - ENH: Allows to use chip ids 1 to 4

27c5281a - ENH: set arbitrary chip ids per chip

14b06f3b - FIX: codestyle

cfbd706a - FIX: Typo

64b309b5 - ENH: better chip_id map in module_types

e06ce2de - FIX: wrong shape of chip id map

cf6ebb5f - ENH: simplification of extend_maps

Compare with previous version
Toggle commit list
Yannick Manuel Dieter added 1 commit 2 years ago
added 1 commit

22ee8c92 - MAINT: codestyle

Compare with previous version
Yannick Manuel Dieter approved this merge request 2 years ago

approved this merge request
Yannick Manuel Dieter enabled an automatic merge when the pipeline for 22ee8c92 succeeds 2 years ago

enabled an automatic merge when the pipeline for 22ee8c92 succeeds
Yannick Manuel Dieter changed the description 2 years ago

changed the description
Yannick Manuel Dieter aborted the automatic merge because source branch was updated 2 years ago

aborted the automatic merge because source branch was updated
Yannick Manuel Dieter added 1 commit 2 years ago
added 1 commit

34d038e7 - BUG: bug fixes

Compare with previous version
Yannick Manuel Dieter added 1 commit 2 years ago
added 1 commit

98e5fab3 - TST: fix tests

Compare with previous version

Please register or sign in to reply